bpo-46353: Fix "pydoc -k" when a module fails to load#30557
Open
dlax wants to merge 1 commit intopython:mainfrom
Open
bpo-46353: Fix "pydoc -k" when a module fails to load#30557dlax wants to merge 1 commit intopython:mainfrom
dlax wants to merge 1 commit intopython:mainfrom
Conversation
The 'spec' value, here coming from pkgutil._get_spec(), may be None because <importer>.find_module() may return None. We account for this in pydoc's ModuleScanner and skip such modules scan.
sobolevn
reviewed
Jan 17, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thank you! Is there any good way to test this?
Contributor
Author
That did not appear easy at first sight. That's typically something that a type checker would catch. |
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
suggested changes
Feb 26, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Could you add a test please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'spec' value, here coming from pkgutil._get_spec(), may be None
because .find_module() may return None. We account for this in
pydoc's ModuleScanner and skip such modules scan.
https://bugs.python.org/issue46353