bpo-45516: add protocol description to the Traversable documentation#29039
Merged
jaraco merged 4 commits intopython:mainfrom Oct 18, 2021
Merged
bpo-45516: add protocol description to the Traversable documentation#29039jaraco merged 4 commits intopython:mainfrom
jaraco merged 4 commits intopython:mainfrom
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
bpo-45516-traversable
branch
from
d0a9fab to
13a6e1c
Compare
Member
Author
|
We can backport this, right? |
jaraco
reviewed
Oct 18, 2021
jaraco
approved these changes
Oct 18, 2021
Member
Not exactly. Docs aren't synced between CPython and importlib_resources, so including this additional detail is going to require adding a lot more unsynchronized reference material to importlib_resources. It's probably not worth it. Let's just maintain the reference material here. |
jaraco
reviewed
Oct 18, 2021
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco
reviewed
Oct 18, 2021
Member
Author
|
Sounds good 😊 |
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
@jaraco: Please replace |
Member
Wait. Did you mean backport to importlib_resources or backport to Python 3.10/3.9? If the latter, then probably yes. |
Member
Author
|
The later, I wasn't sure since you maintain a cpython branch. |
Contributor
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2021
…ythonGH-29039) * bpo-45516: add protocol description to the Traversable documentation Signed-off-by: Filipe Laíns <lains@riseup.net> * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> * Update Lib/importlib/abc.py * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> (cherry picked from commit 4d03de3) Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
|
GH-29348 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2021
…ythonGH-29039) * bpo-45516: add protocol description to the Traversable documentation Signed-off-by: Filipe Laíns <lains@riseup.net> * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> * Update Lib/importlib/abc.py * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> (cherry picked from commit 4d03de3) Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
|
GH-29349 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 31, 2021
…H-29039) * bpo-45516: add protocol description to the Traversable documentation Signed-off-by: Filipe Laíns <lains@riseup.net> * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> * Update Lib/importlib/abc.py * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> (cherry picked from commit 4d03de3) Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 31, 2021
…H-29039) * bpo-45516: add protocol description to the Traversable documentation Signed-off-by: Filipe Laíns <lains@riseup.net> * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> * Update Lib/importlib/abc.py * Update Doc/library/importlib.rst Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> (cherry picked from commit 4d03de3) Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filipe Laíns lains@riseup.net
https://bugs.python.org/issue45516