Fix docs source link for importlib.metadata#29025
Conversation
|
Ugh, docs are a bit of a pain to keep in sync 😅 |
|
@jaraco, remember to change the target branch to main and add the backport label 😁 |
|
We'll want to apply this change to the cpython branch of importlib_metadata also. Otherwise, it might get overwritten during the next update from there. |
|
The importlib_metadata does not contain this link, it is part of the CPython only header. |
|
I applied the change at python/importlib_metadata@90083722648. |
jaraco
requested review from
1st1,
Fidget-Spinner,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
cjw296,
encukou,
ericsnowcurrently,
ericvsmith,
ethanfurman,
ezio-melotti and
gpshead
as code owners
jaraco
requested review from
a team,
markshannon,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy,
tiran,
vsajip and
warsaw
as code owners
Good catch. I not only had to change the target branch, but I had to cherry-pick and force-push the change against |
|
@flying-sheep: Status check is done, and it's a success ✅ . |
|
Thanks @flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
The link broke for Python 3.10 since importlib.metadata was made from a module into a package I think this is trivial enough to not need a bpo issue. Automerge-Triggered-By: GH:jaraco (cherry picked from commit aae18a1) Co-authored-by: Philipp A <flying-sheep@web.de>
|
GH-29330 is a backport of this pull request to the 3.10 branch. |
The link broke for Python 3.10 since importlib.metadata was made from a module into a package I think this is trivial enough to not need a bpo issue. Automerge-Triggered-By: GH:jaraco (cherry picked from commit aae18a1) Co-authored-by: Philipp A <flying-sheep@web.de>
6 participants
The link broke for Python 3.10 since importlib.metadata was made from a module into a package
I think this is trivial enough to not need a bpo issue.
Automerge-Triggered-By: GH:jaraco