[3.5] bpo-30814: Add a test for concurrent relative import. (GH-2580).#2645
[3.5] bpo-30814: Add a test for concurrent relative import. (GH-2580).#2645serhiy-storchaka wants to merge 1 commit intopython:3.5from
Conversation
…a package. (pythonGH-2580). (cherry picked from commit b4baace)
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Hum, the test fails on my Windows VM:
AttributeError: module 'package' has no attribute 'submodule'
If I modify the test to only run 1 loop iteration, the test pass, but fail if run again... It fails randomly.
Please don't add such test to 3.5 yet :-)
|
Hum, I forgot to explain how I tested: I downloaded this PR in my 3.5 checkout of CPython on Windows, and ran the test using "python -m test -m test_concurrency -v test_import". |
|
Just a reminder: I expect to tag 3.5.4rc1 in eleven or twelve hours. If this is a bugfix (not a security fix), and it isn't merged by then, it will probably never be merged into 3.5. |
|
Since Victor's fix was not backported, the test can't be added. |
|
Yeah, I agree that it's too late in the 3.5 cycle (moving to security-only fixes) for work on such old importlib bug. |
4 participants
(cherry picked from commit b4baace)