gh-86650: get_obs_local_part() fails to handle empty local part#24669
gh-86650: get_obs_local_part() fails to handle empty local part#24669ZackerySpytz wants to merge 2 commits intopython:mainfrom
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
|
What exactly is missing for this PR to get applied? It would be great because this bug is affecting my productive system and I have to monkey-patch the email library by myself. |
MaxwellDupre
left a comment
There was a problem hiding this comment.
Ran 1654 tests in 6.561s
OK (skipped=1)
Looks ok.
|
I am getting this bug in a production environment. How is this PR not yet reviewed after- all this time? How can we notify the right people to review this? |
|
@python/email-team |
|
Same here, got this on my production environment, preventing me to upgrade from Python 3.7.3 (bug not present) to a more recent version (bug confirmed in 3.8, 3.9, 3.10, 3.11). Easy to trigger: |
|
Is there an ETA for this please? |
|
I have a competing PR which does not simply silently ignore the problem, but instead raises a defect. My proposed implementation returns a partial message-id which is perhaps less than ideal. |
|
Thank you for your contribution, @ZackerySpytz, but I think that it is not a correct solution. Invalid Message-ID should not be silently truncated. The parsing code should raise HeaderParseError, this will allow to preserve its literal value. See #117934. |
https://bugs.python.org/issue42484