gh-87286: Add a number of LOG_* constants to syslog#24432
Merged
ronaldoussoren merged 10 commits intopython:mainfrom Dec 12, 2023
Merged
gh-87286: Add a number of LOG_* constants to syslog#24432ronaldoussoren merged 10 commits intopython:mainfrom
ronaldoussoren merged 10 commits intopython:mainfrom
Conversation
This adds a number of syslog facilities to the syslogmodule.c. These values are available on macOS.
|
This PR is stale because it has been open for 30 days with no activity. |
akulakov
reviewed
Jul 8, 2021
Contributor
akulakov
left a comment
akulakov
left a comment
There was a problem hiding this comment.
By the way I also was not able to find some of these levels in man 3 syslog on my MacOS, (for example LOG_NETINFO, LOG_RAS, etc - but it's old, 10.12, so were they added more recently? I couldn't find them online either.
Misc/NEWS.d/next/Library/2021-02-03-21-26-57.bpo-43120.4fbCBl.rst
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
stale
ronaldoussoren
changed the title
This fixes a CI warning and matches the pattern used in the documentation for ``os``.
Doc/library/syslog.rst
Outdated
| LOG_INFO | ||
| LOG_DEBUG | ||
|
|
||
| Priority levels (high to low): |
Member
There was a problem hiding this comment.
Should not it be above the previous list?
Member
There was a problem hiding this comment.
Could be, currently it renders like this:
Where this text is the "description details" of the last "description term":
hugovk
reviewed
Dec 8, 2023
Member
|
This now fixes all but one of the Sphinx warnings in this file! 👍 If you feel like polishing it off, we can fix the last one too: This module wraps the system ``syslog`` family of routines. A pure Python
library that can speak to a syslog server is available in the
-:mod:`logging.handlers` module as :class:`SysLogHandler`.
+:mod:`logging.handlers` module as :class:`~logging.handlers.SysLogHandler`.And then remove |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
AlexWaygood
reviewed
Dec 8, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
terryjreedy
reviewed
Dec 12, 2023
Comment on lines
+2
to
+3
| :const:`LOG_INSTALL`, :const:`LOG_RAS`, and :const:`LOG_LAUNCHD` tot the | ||
| :mod:`syslog` module, all of them constants on used on macOS. |
Member
There was a problem hiding this comment.
I believe 'tot' should be 'to' and 'constants on used on' should be 'constants used on'.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
* bpo-43120: Add a number of LOG_* constants to syslog This adds a number of syslog facilities to the syslogmodule.c. These values are available on macOS. * Switch contant documentation to the data directive This fixes a CI warning and matches the pattern used in the documentation for ``os``. * Update Doc/library/syslog.rst Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
* bpo-43120: Add a number of LOG_* constants to syslog This adds a number of syslog facilities to the syslogmodule.c. These values are available on macOS. * Switch contant documentation to the data directive This fixes a CI warning and matches the pattern used in the documentation for ``os``. * Update Doc/library/syslog.rst Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a number of syslog facilities to the syslogmodule.c.
These values are available on macOS.