gh-83074: Ignore EACCES, ENOSYS in copyxattr#21430
Open
tiran wants to merge 1 commit intopython:mainfrom
Open
Conversation
:func:`shutil.copystat` now ignores :const:`errno.ENOSYS` and :const:`errno.EACCES` when copying extended file attributes. :func:`os.listxattr` can fail with ENOSYS on some file systems (e.g. NFS). An LSM may block :func:`os.setxattr` for security attributes like ``security.selinux``. Signed-off-by: Christian Heimes <christian@python.org>
tiran
added
type-bug
Member
Author
|
I am not sure I'm fond of silently ignoring errors -- that can have security implications since the result might not be as expected. |
|
Also fixes bpo-38633 |
Contributor
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
Contributor
|
erlend-aasland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:func:
shutil.copystatnow ignores :const:errno.ENOSYSand:const:
errno.EACCESwhen copying extended file attributes.:func:
os.listxattrcan fail with ENOSYS on some file systems (e.g. NFS).An LSM may block :func:
os.setxattrfor security attributes likesecurity.selinux.Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue38893