X Tutup
Skip to content

gh-145448: Fix REPL tab completion cursor position in pending wrap state #145727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

gh-145448: Fix REPL tab completion cursor position in pending wrap state #145727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions Lib/_pyrepl/unix_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,8 @@ def __write_changed_line(self, y, oldline, newline, px_coord):
self.__move(x_coord, y)
self.__write_code(self.ich1)
self.__write(newline[x_pos])
self.posxy = x_coord + character_width, y
new_x = x_coord + character_width
self.posxy = min(new_x, self.width - 1), y

# if it's a single character change in the middle of the line
elif (
Expand All @@ -686,7 +687,8 @@ def __write_changed_line(self, y, oldline, newline, px_coord):
character_width = wlen(newline[x_pos])
self.__move(x_coord, y)
self.__write(newline[x_pos])
self.posxy = x_coord + character_width, y
new_x = x_coord + character_width
self.posxy = min(new_x, self.width - 1), y

# if this is the last character to fit in the line and we edit in the middle of the line
elif (
Expand All @@ -713,7 +715,14 @@ def __write_changed_line(self, y, oldline, newline, px_coord):
if wlen(oldline) > wlen(newline):
self.__write_code(self._el)
self.__write(newline[x_pos:])
self.posxy = wlen(newline), y
# When writing reaches the last column, the terminal enters
# "pending wrap" state where the cursor physically stays at
# width-1. Record position accordingly so CUB calculations
# use the correct physical cursor position (gh-145448).
newline_width = wlen(newline)
if newline_width >= self.width:
newline_width = self.width - 1
self.posxy = newline_width, y

if "\x1b" in newline:
# ANSI escape characters are present, so we can't assume
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-09-00-00-02.gh-issue-145448.repl-cursor.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixed REPL tab completion cursor moving backward by one cell in terminals
that correctly handle CUB (Cursor Backward) in pending wrap state, such as
xterm and Ghostty.
Loading
X Tutup