X Tutup
Skip to content

gh-145688: Fix _get_protocol_attrs matching user classes named "Protocol" or "Generic" #145724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −1
Open

gh-145688: Fix _get_protocol_attrs matching user classes named "Protocol" or "Generic" #145724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0c8e43
gh-145688: Fix _get_protocol_attrs matching user classes named "Proto…
mvanhorn Mar 10, 2026
42c3750
gh-145688: Handle typing_extensions.Protocol in _get_protocol_attrs
mvanhorn Mar 10, 2026
ff6435a
gh-145688: Use identity check instead of name+module allowlist
mvanhorn Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4574,6 +4574,19 @@ def c(self) -> int: return 5
with self.assertRaisesRegex(TypeError, "not a Protocol"):
get_protocol_members(ConcreteInherit())

def test_get_protocol_members_named_protocol_or_generic(self):
# gh-145688: Protocols named "Protocol" or "Generic" should still
# have their members collected correctly.
class Protocol(typing.Protocol):
a: int

self.assertEqual(get_protocol_members(Protocol), {'a'})

class Generic(typing.Protocol):
b: str

self.assertEqual(get_protocol_members(Generic), {'b'})

def test_is_protocol(self):
self.assertTrue(is_protocol(Proto))
self.assertTrue(is_protocol(Point))
Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1884,7 +1884,7 @@ def _get_protocol_attrs(cls):
"""
attrs = set()
for base in cls.__mro__[:-1]: # without object
if base.__name__ in {'Protocol', 'Generic'}:
if base is Protocol or base is Generic:
continue
try:
annotations = base.__annotations__
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-09-00-00-00.gh-issue-145688.protocol-name.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed :func:`typing.get_protocol_members` returning empty results for
:class:`typing.Protocol` subclasses named ``"Protocol"`` or ``"Generic"``.
Loading
X Tutup