X Tutup
Skip to content

gh-145675: Raise SyntaxError when constants are used as an identifier #145690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-145675: Raise SyntaxError when constants are used as an identifier #145690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_ast/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ def test_constant_as_unicode_name(self):
("None", b"N\xc2\xbane"),
]
for constant in constants:
with self.assertRaisesRegex(ValueError,
with self.assertRaisesRegex(SyntaxError,
f"identifier field can't represent '{constant[0]}' constant"):
ast.parse(constant[1], mode="eval")

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-03-09-17-19-04.gh-issue-145675.9YPpYi.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Raise :exc:`SyntaxError` when constants ``True``, ``False`` or ``None`` are
used as an identifier after NFKC normalization.
2 changes: 1 addition & 1 deletion Parser/pegen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ _PyPegen_new_identifier(Parser *p, const char *n)
};
for (int i = 0; forbidden[i] != NULL; i++) {
if (_PyUnicode_EqualToASCIIString(id, forbidden[i])) {
PyErr_Format(PyExc_ValueError,
RAISE_SYNTAX_ERROR(
"identifier field can't represent '%s' constant",
forbidden[i]);
Py_DECREF(id);
Expand Down
Loading
X Tutup