X Tutup
Skip to content

gh-138568: Make help mode in PyREPL not exit on empty line input#143512

Merged
ambv merged 5 commits intopython:mainfrom
ambv:revive-138569
Jan 7, 2026
Merged

gh-138568: Make help mode in PyREPL not exit on empty line input#143512
ambv merged 5 commits intopython:mainfrom
ambv:revive-138569

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jan 7, 2026 •
edited by bedevere-app bot
Loading

This revives gh-138569 that was automatically closed when the original PR's author @yihong0618 deleted their cpython repository fork.

@ambv ambv requested a review from AA-Turner as a code owner January 7, 2026 11:21
@bedevere-app bedevere-app bot mentioned this pull request Jan 7, 2026
Closed
@yihong0618
Copy link
Contributor

yihong0618 commented Jan 7, 2026

so sorry for that...

@ambv ambv changed the title gh-138568: Make help mode in PyREPL not exist on empty line gh-138568: Make help mode in PyREPL not exit on empty line input Jan 7, 2026
@ambv ambv merged commit b3e4a34 into python:main Jan 7, 2026
85 of 87 checks passed
@ambv
Copy link
Contributor Author

ambv commented Jan 7, 2026

Don't worry about it, @yihong0618. As you can see, it wasn't hard to recover your work.

@ambv ambv added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 7, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 7, 2026

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jan 7, 2026

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2026
@ambv @yihong0618 @miss-islington
pythongh-138568: Make help mode in PyREPL not exit on empty line in…
e793280 
…put (pythonGH-143512)

(cherry picked from commit b3e4a34)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong0618 <zouzou0208@gmail.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 7, 2026

Sorry, @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b3e4a3462f6011cacdfc58c565c69e4d7de6b9cd 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jan 7, 2026

GH-143519 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 7, 2026
ambv added a commit to ambv/cpython that referenced this pull request Jan 7, 2026
@ambv @yihong0618
[3.13] pythongh-138568: Make help mode in PyREPL not exit on empty …
b3b98cb 
…line input (pythonGH-143512)

(cherry picked from commit b3e4a34)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong0618 <zouzou0208@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 7, 2026

GH-143520 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 7, 2026
ambv added a commit that referenced this pull request Jan 7, 2026
@miss-islington @ambv @yihong0618
[3.14] gh-138568: Make help mode in PyREPL not exit on empty line i…
63f8a86 
…nput (GH-143512) (GH-143519)

(cherry picked from commit b3e4a34)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: yihong0618 <zouzou0208@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 7, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.14 (tier-2) has failed when building commit 63f8a86.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1772/builds/773) and take a look at the build logs.
  4. Check if the failure is related to this commit (63f8a86) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1772/builds/773

Failed tests:

  • test_urllib2net

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 12, done.        
remote: Counting objects:  12% (1/8)        
remote: Counting objects:  25% (2/8)        
remote: Counting objects:  37% (3/8)        
remote: Counting objects:  50% (4/8)        
remote: Counting objects:  62% (5/8)        
remote: Counting objects:  75% (6/8)        
remote: Counting objects:  87% (7/8)        
remote: Counting objects: 100% (8/8)        
remote: Counting objects: 100% (8/8), done.        
remote: Total 12 (delta 7), reused 7 (delta 7), pack-reused 4 (from 2)        
From https://github.com/python/cpython
 * branch                    3.14       -> FETCH_HEAD
Note: switching to '63f8a863d15d228bdefc6082b2772031c1a0c959'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 63f8a863d15 [3.14] gh-138568: Make `help` mode in PyREPL not exit on empty line input (GH-143512) (GH-143519)
Switched to and reset branch '3.14'

make: *** [buildbottest] Error 2

@ambv
Copy link
Contributor Author

ambv commented Jan 7, 2026

The buildbot failure's unrelated. It's a "Resource 'ftp://www.pythontest.net/' is not available" error.

ambv added a commit that referenced this pull request Jan 7, 2026
@ambv @yihong0618
[3.13] gh-138568: Make help mode in PyREPL not exit on empty line i…
ad99027 
…nput (GH-143512) (GH-143520)

(cherry picked from commit b3e4a34)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong0618 <zouzou0208@gmail.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@ambv @yihong0618 @thunder-coding
pythongh-138568: Make help mode in PyREPL not exit on empty line in…
1014368 
…put (python#143512)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong0618 <zouzou0208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambv @yihong0618 @bedevere-bot
X Tutup