gh-122431: update error message for negative nelements in readline_append_h… by cla7aye15I4nd · Pull Request #143075 · python/cpython

cla7aye15I4nd · 2025-12-22T16:30:18Z

This pull request makes a minor wording correction to an error message in the readline_append_history_file_impl function to clarify the requirement for the nelements parameter.

Updated the error message in readline_append_history_file_impl to state that "nelements must be non-negative" instead of "positive", improving accuracy and clarity. (Modules/readline.c)

Issue: Segmentation Fault in append_history_file of readline #122431

…istory_file_impl

python-cla-bot · 2025-12-22T16:30:22Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-12-22T16:30:22Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity

Please add a news entry, as this seems to be user-facing.

bedevere-app · 2025-12-22T20:53:35Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity

LGTM, thanks!

miss-islington-app · 2025-12-23T04:35:27Z

Thanks @cla7aye15I4nd for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…append_history_file` (pythonGH-143075) "positive" -> "non-negative", since zero is included. (cherry picked from commit a273bc9) Co-authored-by: Zheng Yu <dataisland@outlook.com>

bedevere-app · 2025-12-23T04:35:39Z

GH-143090 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-12-23T04:35:43Z

GH-143091 is a backport of this pull request to the 3.13 branch.

ZeroIntensity · 2025-12-23T04:36:07Z

Congrats on your first contribution :)

….append_history_file` (GH-143075) (GH-143091) gh-122431: Correct the non-negative error message in `readline.append_history_file` (GH-143075) "positive" -> "non-negative", since zero is included. (cherry picked from commit a273bc9) Co-authored-by: Zheng Yu <dataisland@outlook.com>

….append_history_file` (GH-143075) (GH-143090) gh-122431: Correct the non-negative error message in `readline.append_history_file` (GH-143075) "positive" -> "non-negative", since zero is included. (cherry picked from commit a273bc9) Co-authored-by: Zheng Yu <dataisland@outlook.com>

bedevere-bot · 2025-12-23T19:27:12Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Refleaks 3.14 (tier-1) has failed when building commit aee8c21.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1682/builds/380) and take a look at the build logs.
Check if the failure is related to this commit (aee8c21) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1682/builds/380

Failed tests:

test_external_inspection
test_httpservers

Failed subtests:

test_large_content_length_truncated - test.test_httpservers.CGIHTTPServerTestCase.test_large_content_length_truncated

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\single.py", line 236, in _runtest_env_changed_exc
    return
ResourceWarning: unclosed <socket.socket fd=456, family=2, type=1, proto=0, laddr=('127.0.0.1', 51044), raddr=('127.0.0.1', 51043)>


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 524, in temp_dir
    os.mkdir(path)
    ~~~~~~~~^^^^^^
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_8988�'
Stack (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 138, in <module>
    main()
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 133, in main
    with os_helper.temp_cwd(work_dir, quiet=True):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 141, in __enter__
    return next(self.gen)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 540, in temp_dir
    yield path
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 599, in temp_cwd
    yield cwd_dir
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 134, in main
    worker_process(worker_json)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 120, in worker_process
    sys.exit(0)
    ~~~~~~~~^^^
SystemExit: 0


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\single.py", line 236, in _runtest_env_changed_exc
    return
ResourceWarning: unclosed <socket.socket fd=808, family=2, type=1, proto=0, laddr=('127.0.0.1', 63956), raddr=('127.0.0.1', 63955)>


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\__init__.py", line 208, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_6096�'


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\test_httpservers.py", line 1139, in test_large_content_length_truncated
    res = self.request('/cgi-bin/file1.py', 'POST', b'x', headers)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\test_httpservers.py", line 131, in request
    self.connection.request(method, uri, body, headers)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\http\client.py", line 1358, in request
    self._send_request(method, url, body, headers, encode_chunked)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\http\client.py", line 1404, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\http\client.py", line 1353, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\http\client.py", line 1152, in _send_output
    self.send(chunk)
    ~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\http\client.py", line 1077, in send
    self.sock.sendall(data)
    ~~~~~~~~~~~~~~~~~^^^^^^
ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
                     "__main__", mod_spec)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
    ~~~~^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 138, in <module>
    main()
    ~~~~^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 133, in main
    with os_helper.temp_cwd(work_dir, quiet=True):
         ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
         ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 545, in temp_dir
    rmtree(path)
    ~~~~~~^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 497, in rmtree
    _rmtree(path)
    ~~~~~~~^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 441, in _rmtree
    _waitfor(lambda p: _force_run(p, os.rmdir, p), path)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 441, in <lambda>
    _waitfor(lambda p: _force_run(p, os.rmdir, p), path)
                       ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\__init__.py", line 219, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_6096�'

fix: update error message for negative nelements in readline_append_h…

0a48bb4

…istory_file_impl

bedevere-app bot added the awaiting review label Dec 22, 2025

bedevere-app bot mentioned this pull request Dec 22, 2025

Segmentation Fault in append_history_file of readline #122431

Closed

StanFromIreland added the skip news label Dec 22, 2025

StanFromIreland requested a review from ZeroIntensity December 22, 2025 20:33

ZeroIntensity reviewed Dec 22, 2025

View reviewed changes

ZeroIntensity removed the skip news label Dec 22, 2025

ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 22, 2025

📜🤖 Added by blurb_it.

55598d7

ZeroIntensity approved these changes Dec 23, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Dec 23, 2025

ZeroIntensity merged commit a273bc9 into python:main Dec 23, 2025
50 checks passed

bedevere-app bot removed the awaiting merge label Dec 23, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 23, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-122431: update error message for negative nelements in readline_append_h…#143075

gh-122431: update error message for negative nelements in readline_append_h…#143075
ZeroIntensity merged 2 commits intopython:mainfrom
cla7aye15I4nd:fix-readline-err-message

cla7aye15I4nd commented Dec 22, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

python-cla-bot bot commented Dec 22, 2025 •

edited

Loading

Uh oh!

bedevere-app bot commented Dec 22, 2025

Uh oh!

ZeroIntensity left a comment

Uh oh!

bedevere-app bot commented Dec 22, 2025

Uh oh!

ZeroIntensity left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Dec 23, 2025

Uh oh!

bedevere-app bot commented Dec 23, 2025

Uh oh!

bedevere-app bot commented Dec 23, 2025

Uh oh!

ZeroIntensity commented Dec 23, 2025

Uh oh!

bedevere-bot commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

cla7aye15I4nd commented Dec 22, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Dec 22, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app bot commented Dec 22, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Dec 23, 2025

Uh oh!

bedevere-app bot commented Dec 23, 2025

Uh oh!

bedevere-app bot commented Dec 23, 2025

Uh oh!

ZeroIntensity commented Dec 23, 2025

Uh oh!

bedevere-bot commented Dec 23, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cla7aye15I4nd commented Dec 22, 2025 •

edited by bedevere-app bot

Loading

python-cla-bot bot commented Dec 22, 2025 •

edited

Loading