X Tutup
Skip to content

gh-143057: avoid lock in tracemalloc APIs when it is not enabled#143065

Merged
kumaraditya303 merged 4 commits intopython:mainfrom
kumaraditya303:tracemalloc
Dec 22, 2025
Merged

gh-143057: avoid lock in tracemalloc APIs when it is not enabled#143065
kumaraditya303 merged 4 commits intopython:mainfrom
kumaraditya303:tracemalloc

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 22, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 22, 2025
Closed
@kumaraditya303 kumaraditya303 force-pushed the tracemalloc branch 2 times, most recently from 1d161f5 to aa08d9d Compare December 22, 2025 09:33
Yhg1s
Yhg1s reviewed Dec 22, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 marked this pull request as ready for review December 22, 2025 12:00
Yhg1s
Yhg1s approved these changes Dec 22, 2025
View reviewed changes
@kumaraditya303 @Yhg1s
Update Misc/NEWS.d/next/Core_and_Builtins/2025-12-22-12-03-09.gh-issu…
ba336b1 
…e-143057.Majsre.rst

Co-authored-by: T. Wouters <thomas@python.org>
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 22, 2025

@Yhg1s Should this be backported to 3.14?

@ngoldbaum
Copy link
Contributor

ngoldbaum commented Dec 22, 2025 •
edited
Loading

@Yhg1s Should this be backported to 3.14?

I think so yes. I like @colesbury's rule of thumb for this, I hope he doesn't mind me quoting something he said on discord:

I think it's often worth it to backport small changes that avoid scaling bottlenecks if we have a bug report or think it's likely that people are running into them.

I think it's not worth backporting small performance improvements.

Roughly: if something is accidentally O(N^2), it's a bug. If something is 10% faster, it's a performance improvement.

colesbury
colesbury approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@kumaraditya303 kumaraditya303 added performance Performance or resource usage topic-free-threading needs backport to 3.14 bugs and security fixes labels Dec 22, 2025
@kumaraditya303 kumaraditya303 merged commit e728b00 into python:main Dec 22, 2025
52 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 22, 2025

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the tracemalloc branch December 22, 2025 15:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2025
@kumaraditya303 @miss-islington
pythongh-143057: avoid locking in tracemalloc C-APIs when it is not…
88eb32a 
… enabled (pythonGH-143065)

(cherry picked from commit e728b00)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 22, 2025

GH-143071 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 22, 2025
@kumaraditya303 kumaraditya303 mentioned this pull request Dec 22, 2025
Closed
kumaraditya303 added a commit that referenced this pull request Dec 22, 2025
@miss-islington @kumaraditya303
[3.14] gh-143057: avoid locking in tracemalloc C-APIs when it is no…
98f6db7 
…t enabled (GH-143065) (#143071)

gh-143057: avoid locking in `tracemalloc` C-APIs when it is not enabled (GH-143065)
(cherry picked from commit e728b00)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@colesbury colesbury mentioned this pull request Dec 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@Yhg1s Yhg1s Yhg1s approved these changes

Assignees

No one assigned

Labels

performance Performance or resource usage topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @ngoldbaum @colesbury @Yhg1s
X Tutup