gh-143006: add type check in float_richcompare()#143053
Closed
skirpichev wants to merge 2 commits intopython:mainfrom
Closed
gh-143006: add type check in float_richcompare()#143053skirpichev wants to merge 2 commits intopython:mainfrom
skirpichev wants to merge 2 commits intopython:mainfrom
Conversation
skirpichev
added
needs backport to 3.13
Member
Author
|
I'm not sure if it worth. But the check is cheap (when it is False). See issue thread for alternative. |
vstinner
reviewed
Dec 22, 2025
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
|
@serhiy-storchaka: Do you want to double check the fix? |
Member
Author
|
Closed in favor of other approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
float_richcomparevia re-entrant__neg__#143006