X Tutup
Skip to content

gh-98552: flush std streams in the multiprocessing forkserver before fork#141849

Merged
gpshead merged 2 commits intopython:mainfrom
gpshead:mp-forkserver-flush-b4-fork
Nov 22, 2025
Merged

gh-98552: flush std streams in the multiprocessing forkserver before fork#141849
gpshead merged 2 commits intopython:mainfrom
gpshead:mp-forkserver-flush-b4-fork

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Nov 22, 2025 •
edited by bedevere-app bot
Loading

A minor bug discovered by multiple authors working on a fix for the original bug in the linked issue.

@bedevere-app bedevere-app bot mentioned this pull request Nov 22, 2025
Closed
@gpshead gpshead marked this pull request as ready for review November 22, 2025 18:01
@gpshead gpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 22, 2025
@gpshead gpshead enabled auto-merge (squash) November 22, 2025 18:07
@gpshead gpshead merged commit 58badb1 into python:main Nov 22, 2025
52 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 22, 2025

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2025
@gpshead @miss-islington
pythongh-98552: flush std streams in the multiprocessing forkserver b…
4125fe2 
…efore fork (pythonGH-141849)

* flush std streams in the multiprocessing forkserver before fork

* NEWS
(cherry picked from commit 58badb1)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 22, 2025

GH-141851 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 22, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2025
@gpshead @miss-islington
pythongh-98552: flush std streams in the multiprocessing forkserver b…
344e53d 
…efore fork (pythonGH-141849)

* flush std streams in the multiprocessing forkserver before fork

* NEWS
(cherry picked from commit 58badb1)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 22, 2025

GH-141852 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 22, 2025
gpshead added a commit that referenced this pull request Nov 22, 2025
@miss-islington @gpshead
[3.14] gh-98552: flush std streams in the multiprocessing forkserver …
061965c 
…before fork (GH-141849) (#141851)

gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849)

* flush std streams in the multiprocessing forkserver before fork

* NEWS
(cherry picked from commit 58badb1)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
gpshead added a commit that referenced this pull request Nov 22, 2025
@miss-islington @gpshead
[3.13] gh-98552: flush std streams in the multiprocessing forkserver …
60c02ff 
…before fork (GH-141849) (#141852)

gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849)

* flush std streams in the multiprocessing forkserver before fork

* NEWS
(cherry picked from commit 58badb1)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@gpshead
Copy link
Member Author

gpshead commented Nov 23, 2025

looks like this was already done for #135335, just earlier in the code from where I had been looking. reverting.

@gpshead gpshead deleted the mp-forkserver-flush-b4-fork branch November 23, 2025 09:20
gpshead added a commit to gpshead/cpython that referenced this pull request Nov 23, 2025
@gpshead
Revert (unneeded, already done elsewhere) "pythongh-98552: flush std …
355f816 
…streams in the multiprocessing forkserver before fork (python#141849)"

This reverts commit 58badb1.
gpshead added a commit that referenced this pull request Nov 23, 2025
@gpshead
gh-98552: Revert (unneeded, already done elsewhere) "flush std stream…
614a28b 
…s in the multiprocessing forkserver before fork (#141849)" (#141871)

Revert (unneeded, already done elsewhere) "gh-98552: flush std streams in the multiprocessing forkserver before fork (#141849)"

This reverts commit 58badb1.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2025
@gpshead @miss-islington
pythongh-98552: Revert (unneeded, already done elsewhere) "flush std …
43a22ae 
…streams in the multiprocessing forkserver before fork (pythonGH-141849)" (pythonGH-141871)

Revert (unneeded, already done elsewhere) "pythongh-98552: flush std streams in the multiprocessing forkserver before fork (pythonGH-141849)"

This reverts commit 58badb1.
(cherry picked from commit 614a28b)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@miss-islington miss-islington mentioned this pull request Nov 23, 2025
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2025
@gpshead @miss-islington
pythongh-98552: Revert (unneeded, already done elsewhere) "flush std …
ec1b2ae 
…streams in the multiprocessing forkserver before fork (pythonGH-141849)" (pythonGH-141871)

Revert (unneeded, already done elsewhere) "pythongh-98552: flush std streams in the multiprocessing forkserver before fork (pythonGH-141849)"

This reverts commit 58badb1.
(cherry picked from commit 614a28b)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@miss-islington miss-islington mentioned this pull request Nov 23, 2025
Merged
gpshead added a commit that referenced this pull request Nov 23, 2025
@miss-islington @gpshead
[3.13] gh-98552: Revert (unneeded, already done elsewhere) "flush std…
e2d320b 
… streams in the multiprocessing forkserver before fork (GH-141849)" (GH-141871) (#141873)

gh-98552: Revert (unneeded, already done elsewhere) "flush std streams in the multiprocessing forkserver before fork (GH-141849)" (GH-141871)

Revert (unneeded, already done elsewhere) "gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849)"

This reverts commit 58badb1.
(cherry picked from commit 614a28b)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
gpshead added a commit that referenced this pull request Nov 23, 2025
@miss-islington @gpshead
[3.14] gh-98552: Revert (unneeded, already done elsewhere) "flush std…
59ab1ed 
… streams in the multiprocessing forkserver before fork (GH-141849)" (GH-141871) (#141872)

gh-98552: Revert (unneeded, already done elsewhere) "flush std streams in the multiprocessing forkserver before fork (GH-141849)" (GH-141871)

Revert (unneeded, already done elsewhere) "gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849)"

This reverts commit 58badb1.
(cherry picked from commit 614a28b)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 23, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit e2d320b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/1592) and take a look at the build logs.
  4. Check if the failure is related to this commit (e2d320b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/1592

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/test_os.py", line 4342, in test_timerfd_ns_poll
    self.check_timerfd_poll(True)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/test_os.py", line 4327, in check_timerfd_poll
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 4 != 1


Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/test_os.py", line 4342, in test_timerfd_ns_poll
    self.check_timerfd_poll(True)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/test_os.py", line 4327, in check_timerfd_poll
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@gpshead @StanFromIreland
pythongh-98552: flush std streams in the multiprocessing forkserver b…
8169441 
…efore fork (python#141849)

* flush std streams in the multiprocessing forkserver before fork

* NEWS
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@gpshead @StanFromIreland
pythongh-98552: Revert (unneeded, already done elsewhere) "flush std …
24a79ae 
…streams in the multiprocessing forkserver before fork (python#141849)" (python#141871)

Revert (unneeded, already done elsewhere) "pythongh-98552: flush std streams in the multiprocessing forkserver before fork (python#141849)"

This reverts commit 58badb1.
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@gpshead @ashm-dev
pythongh-98552: flush std streams in the multiprocessing forkserver b…
293a740 
…efore fork (python#141849)

* flush std streams in the multiprocessing forkserver before fork

* NEWS
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@gpshead @ashm-dev
pythongh-98552: Revert (unneeded, already done elsewhere) "flush std …
f7dcd4e 
…streams in the multiprocessing forkserver before fork (python#141849)" (python#141871)

Revert (unneeded, already done elsewhere) "pythongh-98552: flush std streams in the multiprocessing forkserver before fork (python#141849)"

This reverts commit 58badb1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gpshead @bedevere-bot
X Tutup