gh-141141: Make `base64.b85decode` thread safe by beneltayar · Pull Request #141149 · python/cpython

beneltayar · 2025-11-06T15:05:18Z

Fixes a thread safety issue with base64.b85decode

Issue: base64.b85decode thread safety issue #141141

python-cla-bot · 2025-11-06T15:05:22Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-11-06T15:05:23Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Lib/base64.py

serhiy-storchaka

LGTM. 👍

miss-islington-app · 2025-11-07T10:47:29Z

Thanks @beneltayar for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

(cherry picked from commit a7bf27f) Co-authored-by: Benel Tayar <86257734+beneltayar@users.noreply.github.com>

bedevere-app · 2025-11-07T10:47:40Z

GH-141184 is a backport of this pull request to the 3.14 branch.

(cherry picked from commit a7bf27f) Co-authored-by: Benel Tayar <86257734+beneltayar@users.noreply.github.com>

bedevere-app · 2025-11-07T10:47:44Z

GH-141185 is a backport of this pull request to the 3.13 branch.

…-141185) (cherry picked from commit a7bf27f) Co-authored-by: Benel Tayar <86257734+beneltayar@users.noreply.github.com>

…-141184) (cherry picked from commit a7bf27f) Co-authored-by: Benel Tayar <86257734+beneltayar@users.noreply.github.com>

bedevere-bot · 2025-11-07T11:43:56Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.13 (tier-2) has failed when building commit 353bfc8.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1404/builds/1385) and take a look at the build logs.
Check if the failure is related to this commit (353bfc8) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1404/builds/1385

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53703), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53705), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53705), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53710), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53712), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53712), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53669), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53671), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53671), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 53656), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53658), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53658), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53727), raddr=('68.183.26.59', 21)>


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/contextlib.py", line 136, in __enter__
    def __enter__(self):
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 53661), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53667), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/contextlib.py", line 136, in __enter__
    def __enter__(self):
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53667), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53673), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/contextlib.py", line 136, in __enter__
    def __enter__(self):
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53673), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 53675), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 53675), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53677), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53677), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 53679), raddr=('68.183.26.59', 21)>


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet
    captured_errnos = [getattr(errno, name, num)
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53707), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53714), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet
    captured_errnos = [getattr(errno, name, num)
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53714), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53721), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet
    captured_errnos = [getattr(errno, name, num)
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53721), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53723), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53723), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53725), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53725), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 53716), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 53718), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 53718), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 53663), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53665), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 53665), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"

bedevere-bot · 2025-11-07T11:58:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Windows 3.x (tier-3) has failed when building commit a7bf27f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/729/builds/9987) and take a look at the build logs.
Check if the failure is related to this commit (a7bf27f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/729/builds/9987

Failed tests:

test_gzip
test_dbm_dumb
test.test_multiprocessing_spawn.test_misc

Failed subtests:

test_large_pool - test.test_multiprocessing_spawn.test_misc.MiscTestCase.test_large_pool
test_readline - test.test_gzip.TestGzip.test_readline
test_readlines - test.test_gzip.TestGzip.test_readlines

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\multiprocessing\spawn.py", line 122, in spawn_main


Traceback (most recent call last):


Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1379, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1341, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1267, in _find_spec
  File "<frozen importlib._bootstrap_external>", line 1314, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1288, in _get_spec
  File "<frozen importlib._bootstrap_external>", line 1391, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1434, in _fill_cache
OSError: [WinError 8] Not enough memory resources are available to process this command: 'C:\\Workspace\\buildarea\\3.x.linaro-win-arm64\\build\\PCbuild\\arm64'
Exception ignored in the internal traceback machinery:


Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1568, in _install_external_importers
ImportError: Frozen object named '_frozen_importlib_external' is invalid
Fatal Python error: _PyImport_InitExternal: external importer setup failed
Python runtime state: core initialized


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\_test_multiprocessing.py", line 7021, in test_large_pool
    rc, out, err = script_helper.assert_python_ok(testfn)
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\script_helper.py", line 182, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\script_helper.py", line 167, in _assert_python
    res.fail(cmd_line)
    ~~~~~~~~^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\script_helper.py", line 80, in fail
    raise AssertionError(f"Process return code is {exitcode}\n"
    ...<10 lines>...
                         f"---")
AssertionError: Process return code is 1
command line: ['C:\\Workspace\\buildarea\\3.x.linaro-win-arm64\\build\\PCbuild\\arm64\\python_d.exe', '-X', 'faulthandler', '-I', '@test_117744_tmpÃ¦']


Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1376, in _find_and_load
  File "<frozen importlib._bootstrap>", line 420, in __enter__
  File "<frozen importlib._bootstrap>", line 459, in _get_module_lock
AttributeError: 'NoneType' object has no attribute 'ref'
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1559, in _install
  File "<frozen importlib._bootstrap>", line 1548, in _setup
  File "<frozen importlib._bootstrap>", line 1514, in _builtin_from_name
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1003, in exec_module
  File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
bject address  : 00000226E43742F0
bject refcount : 1
bject type     : 00007FFB9DC1E140
bject type name: MemoryError
bject repr     : MemoryError()
lost sys.stderr
Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python
Python runtime state: preinitialized


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_gzip.py", line 266, in test_readline
    with gzip.GzipFile(self.filename, 'rb') as f:
         ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\gzip.py", line 208, in __init__
    fileobj = self.myfileobj = builtins.open(filename, mode or 'rb')
                               ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
MemoryError


Traceback (most recent call last):
  File "<frozen getpath>", line 507, in <module>
ModuleNotFoundError: No module named 'traceback'
SystemError: <built-in function readlines> returned NULL without setting an exception


Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1379, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1341, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1267, in _find_spec
Traceback (most recent call last):


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_gzip.py", line 275, in test_readlines
    self.test_write()
    ~~~~~~~~~~~~~~~^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_gzip.py", line 69, in test_write
    with gzip.GzipFile(self.filename, 'wb') as f:
         ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\gzip.py", line 243, in __init__
    self._buffer = io.BufferedWriter(_WriteBufferStream(self),
                   ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     buffer_size=self._buffer_size)
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
MemoryError

bedevere-bot · 2025-11-07T12:20:51Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Windows Non-Debug 3.x (tier-3) has failed when building commit a7bf27f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/730/builds/13464) and take a look at the build logs.
Check if the failure is related to this commit (a7bf27f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/730/builds/13464

Failed tests:

test_http_cookies
test.test_multiprocessing_spawn.test_misc
test_compile
test_zipimport

Failed subtests:

test_large_pool - test.test_multiprocessing_spawn.test_misc.MiscTestCase.test_large_pool
testZip64CruftAndComment - test.test_zipimport.ZStdCompressedZipImportTestCase.testZip64CruftAndComment
test_unquote_large - test.test_http_cookies.CookieTests.test_unquote_large
test_stack_overflow - test.test_compile.TestSpecifics.test_stack_overflow

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\_test_multiprocessing.py", line 7021, in test_large_pool
    rc, out, err = script_helper.assert_python_ok(testfn)
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\support\script_helper.py", line 182, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\support\script_helper.py", line 167, in _assert_python
    res.fail(cmd_line)
    ~~~~~~~~^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\support\script_helper.py", line 80, in fail
    raise AssertionError(f"Process return code is {exitcode}\n"
    ...<10 lines>...
                         f"---")
AssertionError: Process return code is 1
command line: ['C:\\Workspace\\buildarea\\3.x.linaro-win-arm64.nondebug\\build\\PCbuild\\arm64\\python.exe', '-X', 'faulthandler', '-I', '@test_122296_tmpÃ¦']


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\test_zipimport.py", line 902, in testZip64CruftAndComment
    self.doTest(".py", files, "f65536", comment=b"c" * ((1 << 16) - 1))
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\test_zipimport.py", line 159, in doTest
    self.makeZip(files, **kw)
    ~~~~~~~~~~~~^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\test_zipimport.py", line 122, in makeZip
    self.writeZip(z, files, file_comment=file_comment, prefix=prefix)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\test_zipimport.py", line 150, in writeZip
    z.writestr(zinfo, data)
    ~~~~~~~~~~^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\zipfile\__init__.py", line 2020, in writestr
    dest.write(data)
    ~~~~~~~~~~^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\zipfile\__init__.py", line 1332, in write
    data = self._compressor.compress(data)
compression.zstd.ZstdError: Unable to compress Zstandard data: Allocation error : not enough memory


Traceback (test.test_zipimport.ZStdCompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\_test_multiprocessing.py", line 7021, in test_large_pool
    rc, out, err = script_helper.assert_python_ok(testfn)
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\support\script_helper.py", line 182, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\support\script_helper.py", line 167, in _assert_python
    res.fail(cmd_line)
    ~~~~~~~~^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\support\script_helper.py", line 80, in fail
    raise AssertionError(f"Process return code is {exitcode}\n"
    ...<10 lines>...
                         f"---")
AssertionError: Process return code is 1
command line: ['C:\\Workspace\\buildarea\\3.x.linaro-win-arm64.nondebug\\build\\PCbuild\\arm64\\python.exe', '-X', 'faulthandler', '-I', '@test_123944_tmpÃ¦']


Traceback (test.test_zipimport.DeflateCompressedZipImportTestCase.testTraceback) ... ok


Traceback (test.test_zipimport.UncompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\test_http_cookies.py", line 162, in test_unquote_large
    C.load(data)
    ~~~~~~^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\http\cookies.py", line 518, in load
    self.__parse_string(rawdata)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\http\cookies.py", line 539, in __parse_string
    match = patt.match(str, i)
MemoryError


Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\test\test_compile.py", line 1043, in test_stack_overflow
    compile("if a: b\n" * 200000, "<dummy>", "exec")
    ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
MemoryError

Make base64.b85decode thread safe - issue 141141

1c413e0

bedevere-app bot added the awaiting review label Nov 6, 2025

bedevere-app bot mentioned this pull request Nov 6, 2025

base64.b85decode thread safety issue #141141

Closed

📜🤖 Added by blurb_it.

4796813

beneltayar force-pushed the fix-issue-141141 branch from a72aec6 to 0822b89 Compare November 6, 2025 16:08

beneltayar requested review from a team and ericsnowcurrently as code owners November 6, 2025 16:08

beneltayar force-pushed the fix-issue-141141 branch from 0822b89 to 4796813 Compare November 6, 2025 16:09

serhiy-storchaka reviewed Nov 7, 2025

View reviewed changes

Lib/base64.py Outdated Show resolved Hide resolved

rename b85dec_tmp

c4d8f4e

serhiy-storchaka approved these changes Nov 7, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Nov 7, 2025

serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 7, 2025

serhiy-storchaka enabled auto-merge (squash) November 7, 2025 10:41

serhiy-storchaka merged commit a7bf27f into python:main Nov 7, 2025
54 checks passed

bedevere-app bot removed the awaiting merge label Nov 7, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 7, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 7, 2025

serhiy-storchaka pushed a commit that referenced this pull request Nov 7, 2025

[3.13] gh-141141: Make base64.b85decode() thread safe (GH-141149) (GH…

353bfc8

…-141185) (cherry picked from commit a7bf27f) Co-authored-by: Benel Tayar <86257734+beneltayar@users.noreply.github.com>

serhiy-storchaka pushed a commit that referenced this pull request Nov 7, 2025

[3.14] gh-141141: Make base64.b85decode() thread safe (GH-141149) (GH…

cb8b2ba

…-141184) (cherry picked from commit a7bf27f) Co-authored-by: Benel Tayar <86257734+beneltayar@users.noreply.github.com>

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025

pythongh-141141: Make base64.b85decode() thread safe (pythonGH-141149)

3acb5ac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-141141: Make `base64.b85decode` thread safe#141149

gh-141141: Make `base64.b85decode` thread safe#141149
serhiy-storchaka merged 3 commits intopython:mainfrom
beneltayar:fix-issue-141141

beneltayar commented Nov 6, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

python-cla-bot bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

bedevere-app bot commented Nov 6, 2025

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Nov 7, 2025

Uh oh!

bedevere-app bot commented Nov 7, 2025

Uh oh!

bedevere-app bot commented Nov 7, 2025

Uh oh!

bedevere-bot commented Nov 7, 2025

Uh oh!

bedevere-bot commented Nov 7, 2025

Uh oh!

bedevere-bot commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

beneltayar commented Nov 6, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Nov 6, 2025

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Nov 7, 2025

Uh oh!

bedevere-app bot commented Nov 7, 2025

Uh oh!

bedevere-app bot commented Nov 7, 2025

Uh oh!

bedevere-bot commented Nov 7, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Nov 7, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Nov 7, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

beneltayar commented Nov 6, 2025 •

edited by bedevere-app bot

Loading

python-cla-bot bot commented Nov 6, 2025 •

edited

Loading