gh-126014: test_makefile_test_folders: Ignore basically-empty directories#140466
Merged
vstinner merged 2 commits intopython:mainfrom Jan 27, 2026
Merged
gh-126014: test_makefile_test_folders: Ignore basically-empty directories#140466vstinner merged 2 commits intopython:mainfrom
vstinner merged 2 commits intopython:mainfrom
Conversation
…irectories The code in test_makefile was attempting to ignore any any non-interesting files, but missed some corners: 1. There is never a *file* called `__pycache__`. 2. A directory containing only a `__pycache__` subdirectory should be ignored. 3. A directory containing only hidden files should be ignored. Simplify this all into a couple of filters that let us check for empty lists.
JelleZijlstra
approved these changes
Jan 27, 2026
vstinner
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2026
…irectories (pythonGH-140466) The code in test_makefile was attempting to ignore any non-interesting files, but missed some corners: 1. There is never a *file* called `__pycache__`. 2. A directory containing only a `__pycache__` subdirectory should be ignored. 3. A directory containing only hidden files should be ignored. Simplify this all into a couple of filters that let us check for empty lists. (cherry picked from commit 17d447e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2026
…irectories (pythonGH-140466) The code in test_makefile was attempting to ignore any non-interesting files, but missed some corners: 1. There is never a *file* called `__pycache__`. 2. A directory containing only a `__pycache__` subdirectory should be ignored. 3. A directory containing only hidden files should be ignored. Simplify this all into a couple of filters that let us check for empty lists. (cherry picked from commit 17d447e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
|
GH-144268 is a backport of this pull request to the 3.13 branch. |
|
GH-144269 is a backport of this pull request to the 3.14 branch. |
Member
|
Merged, thanks for the fix. |
vstinner
pushed a commit
that referenced
this pull request
Jan 27, 2026
…directories (GH-140466) (#144268) gh-126014: test_makefile_test_folders: Ignore basically-empty directories (GH-140466) The code in test_makefile was attempting to ignore any non-interesting files, but missed some corners: 1. There is never a *file* called `__pycache__`. 2. A directory containing only a `__pycache__` subdirectory should be ignored. 3. A directory containing only hidden files should be ignored. Simplify this all into a couple of filters that let us check for empty lists. (cherry picked from commit 17d447e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
vstinner
pushed a commit
that referenced
this pull request
Jan 27, 2026
…directories (GH-140466) (#144269) gh-126014: test_makefile_test_folders: Ignore basically-empty directories (GH-140466) The code in test_makefile was attempting to ignore any non-interesting files, but missed some corners: 1. There is never a *file* called `__pycache__`. 2. A directory containing only a `__pycache__` subdirectory should be ignored. 3. A directory containing only hidden files should be ignored. Simplify this all into a couple of filters that let us check for empty lists. (cherry picked from commit 17d447e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…irectories (python#140466) The code in test_makefile was attempting to ignore any non-interesting files, but missed some corners: 1. There is never a *file* called `__pycache__`. 2. A directory containing only a `__pycache__` subdirectory should be ignored. 3. A directory containing only hidden files should be ignored. Simplify this all into a couple of filters that let us check for empty lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in
test_makefilewas attempting to ignore any any non-interesting files, but missed some corners:__pycache__.__pycache__subdirectory should be ignored.Simplify this all into a couple of filters that let us check for empty lists.
Bisecting across the removal of
Lib/test/support/interpreters/is likely to trigger this bug.__pycache__intest_makefile_test_folders#126014