gh-138489: Add missing build-details.json step for building wasm#139302
Merged
FFY00 merged 3 commits intopython:mainfrom Oct 4, 2025
Merged
gh-138489: Add missing build-details.json step for building wasm#139302FFY00 merged 3 commits intopython:mainfrom
build-details.json step for building wasm#139302FFY00 merged 3 commits intopython:mainfrom
Conversation
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
HoKim98
changed the title
build-details.json step for building wasmbuild-details.json step for building wasm
picnixz
changed the title
build-details.json step for building wasmbuild-details.json step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
HoKim98
requested review from
AA-Turner,
emmatyping and
erlend-aasland
as code owners
Member
|
Sorry, it's far too easy to click the 'copilot' button, this was absolutely not my intent! A |
AA-Turner
reviewed
Sep 24, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
HoKim98
force-pushed
the
fix/wasm-build-details.json
branch
from
f9a947b to
6bbad6d
Compare
Member
|
Confirmed locally this also fixes #137878 $ wasmtime --dir /opt/wasi-python/ /opt/wasi-python/bin/python3.wasm
Python 3.15.0a0 (heads/fix/wasm-build-details.json-dirty:6bbad6d6cc2, Sep 24 2025, 10:33:33) [Clang 19.1.5-wasi-sdk (https://github.com/llvm/llvm-project ab4b5a2db582958af1e on wasi
Type "help", "copyright", "credits" or "license" for more information.
warning: can't use pyrepl: No module named 'termios'
>>> import math
>>> math.pi
3.141592653589793 |
emmatyping
approved these changes
Sep 24, 2025
Member
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Thank you! This looks good to me.
FFY00
approved these changes
Oct 4, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2025
…asm (pythonGH-139302) * fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * pythongh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --------- (cherry picked from commit db53ca3) Co-authored-by: Ho Kim <ho.kim@ulagbulag.io> Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-139557 is a backport of this pull request to the 3.14 branch. |
Member
|
I think it's worth backporting this, but it's not critical that this goes into 3.14.0. What do we think? A |
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2025
…asm (pythonGH-139302) * fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * pythongh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --------- (cherry picked from commit db53ca3) Co-authored-by: Ho Kim <ho.kim@ulagbulag.io> Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Backport PR already created at GH-139557, miss-islington doesn't appear to recognise this. A |
danigm
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Oct 7, 2025
…asm (python#139302) * fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * pythongh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> * Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --------- Signed-off-by: Ho Kim <ho.kim@ulagbulag.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this PR just adds a missing
build-details.jsonbuild step on WASM ecosystems (e.g.WASI).When cross-compiling for WASI by
build_wasmorbuild_emscripten, thebuild-details.jsonstep is now included in the build process, just like with native builds.This fixes the
libinstalltask which requires thebuild-details.jsonfile during the process.build-details.jsonis missing on some platforms #138489