gh-134466: Don't run when termios is inaccessible#138911
Merged
ambv merged 3 commits intopython:mainfrom Sep 17, 2025
Merged
Conversation
Without the ability to set required capabilities, the REPL cannot function properly (syntax highlighting and multiline editing can't work). We refuse to work in this degraded state.
ambv
added
needs backport to 3.13
Contributor
|
This looks like it might also improve gh-135329 (adds ignoring |
Contributor
Author
|
Merging this will expose #139027, but that issue exists already and is a separate problem. |
lysnikolaou
approved these changes
Sep 17, 2025
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM! Let's work on #139027 separately.
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2025
) Without the ability to set required capabilities, the REPL cannot function properly (syntax highlighting and multiline editing can't work). We refuse to work in this degraded state. (cherry picked from commit 2fc7004) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
Sorry, @ambv, I could not cleanly backport this to |
|
GH-139029 is a backport of this pull request to the 3.14 branch. |
ambv
added a commit
to ambv/cpython
that referenced
this pull request
Sep 17, 2025
…nGH-138911) Without the ability to set required capabilities, the REPL cannot function properly (syntax highlighting and multiline editing can't work). We refuse to work in this degraded state. (cherry picked from commit 2fc7004) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
GH-139030 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the ability to set required capabilities, the REPL cannot function properly (syntax highlighting and multiline editing can't work).
We refuse to work in this degraded state.