X Tutup
Skip to content

gh-138897: Use _pyrepl.pager for _sitebuiltins._Printer#138898

Merged
ambv merged 6 commits intopython:mainfrom
StanFromIreland:use-pager
Jan 2, 2026
Merged

gh-138897: Use _pyrepl.pager for _sitebuiltins._Printer#138898
ambv merged 6 commits intopython:mainfrom
StanFromIreland:use-pager

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Sep 14, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 14, 2025
Closed
@StanFromIreland StanFromIreland marked this pull request as ready for review September 15, 2025 06:53
@ambv
Copy link
Contributor

ambv commented Sep 16, 2025

Great idea, love it. In fact, you can use the pager always since it's deliberately a rather independent part of PyREPL. pydoc is using it, too (the code was moved from there originally)

@picnixz
Copy link
Member

picnixz commented Sep 16, 2025 •
edited
Loading

In fact, you can use the pager always since it's deliberately a rather independent part of PyREPL

Would it be possible to isolate it outside _pyrepl? (would it also make sense?) Since we have _colorize for colorization support, _pypager.py would make sense (I would suggest the _py prefix to be sure we don't shadow _pager.py modules from users)

@ambv
Copy link
Contributor

ambv commented Sep 16, 2025

Would it be possible to isolate it outside _pyrepl?

Yes, I moved it out of pydoc mostly to be able to type-annotate it, change the API a bit, and make it fully independent of pydoc. I didn't want to make up a top-level module name at the time, but if it makes sense, we can do that.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Sep 16, 2025

Thanks!

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Oct 21, 2025

Friendly ping @ambv :-)

@StanFromIreland StanFromIreland requested a review from ambv November 24, 2025 21:12
@ambv ambv added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 2, 2026
@ambv ambv merged commit 0417dab into python:main Jan 2, 2026
49 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 2, 2026

Thanks @StanFromIreland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
@StanFromIreland @ambv @miss-islington
pythongh-138897: Use _pyrepl.pager for _sitebuiltins._Printer (py…
1707986 
…thonGH-138898)

(cherry picked from commit 0417dab)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2026

GH-143364 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
@StanFromIreland @ambv @miss-islington
pythongh-138897: Use _pyrepl.pager for _sitebuiltins._Printer (py…
cd621bd 
…thonGH-138898)

(cherry picked from commit 0417dab)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2026

GH-143365 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 2, 2026
ambv added a commit that referenced this pull request Jan 2, 2026
@miss-islington @StanFromIreland @ambv
[3.14] gh-138897: Use _pyrepl.pager for _sitebuiltins._Printer (G…
675dfe7 
…H-138898) (GH-143364)

(cherry picked from commit 0417dab)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jan 2, 2026
@miss-islington @StanFromIreland @ambv
[3.13] gh-138897: Use _pyrepl.pager for _sitebuiltins._Printer (G…
c7f1e18 
…H-138898) (GH-143365)

(cherry picked from commit 0417dab)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@StanFromIreland @ambv @thunder-coding
pythongh-138897: Use _pyrepl.pager for _sitebuiltins._Printer (py…
82e82f2 
…thonGH-138898)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @ambv @picnixz
X Tutup