gh-137044: Make resource.RLIM_INFINITY always positive#137511
Merged
serhiy-storchaka merged 3 commits intopython:mainfrom Aug 18, 2025
Merged
gh-137044: Make resource.RLIM_INFINITY always positive#137511serhiy-storchaka merged 3 commits intopython:mainfrom
serhiy-storchaka merged 3 commits intopython:mainfrom
Conversation
It is now a positive integer larger larger than any limited resource value. This simplifies comparison of the resource values. Previously, it could be negative, such as -1 or -3, depending on platform.
encukou
approved these changes
Aug 18, 2025
Member
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
OK, let's do this. It's the practical thing to do; if there are platforms that conform to POSIX in more interesting ways then we'll hopefullly notice in the 3.15 cycle.
Comment on lines
+1
to
+4
| :data:`resource.RLIM_INFINITY` is now always a positive integer larger than | ||
| any limited resource value. This simplifies comparison of the resource | ||
| values. Previously, it could be negative, such as -1 or -3, depending on | ||
| platform. |
Member
There was a problem hiding this comment.
I don't think we test/guarantee that RLIM_INFINITY is bigger than limited values. AFAIK, POSIX would have no problem with RLIM_INFINITY being zero.
So, this should be:
Suggested change
| :data:`resource.RLIM_INFINITY` is now always a positive integer larger than | |
| any limited resource value. This simplifies comparison of the resource | |
| values. Previously, it could be negative, such as -1 or -3, depending on | |
| platform. | |
| :data:`resource.RLIM_INFINITY` is now always a positive integer. | |
| Previously, it could be negative, such as -1 or -3, depending on | |
| platform. |
or:
Suggested change
| :data:`resource.RLIM_INFINITY` is now always a positive integer larger than | |
| any limited resource value. This simplifies comparison of the resource | |
| values. Previously, it could be negative, such as -1 or -3, depending on | |
| platform. | |
| :data:`resource.RLIM_INFINITY` is now always a positive integer. | |
| On supported platforms, it is larger than any limited resource value, | |
| which simplifies comparison of the resource values. | |
| Previously, it could be negative, such as -1 or -3, depending on | |
| platform. |
Member
Author
There was a problem hiding this comment.
https://pubs.opengroup.org/onlinepubs/9799919799/functions/getrlimit.html
The value RLIM_INFINITY, defined in <sys/resource.h>, shall be considered to be larger than any other limit value.
Member
There was a problem hiding this comment.
To be clear, I do not think this should have been merged without this change.
Member
|
This seems to have broken |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Aug 19, 2025
…ythonGH-137511)" This reverts commit 0324c72.
Member
Author
|
Test fix: #137941. |
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…H-137511) It is now a positive integer larger larger than any limited resource value. This simplifies comparison of the resource values. Previously, it could be negative, such as -1 or -3, depending on platform. Deprecation warning is emitted if the old negative value is passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now a positive integer larger than any limited resource value. This simplifies comparison of the resource values. Previously, it could be negative, such as -1 or -3, depending on platform.