X Tutup
Skip to content

gh-79986: Add parsing for References/In-Reply-To email headers#137201

Merged
bitdancer merged 1 commit intopython:mainfrom
elenril:email_references
Dec 11, 2025
Merged

gh-79986: Add parsing for References/In-Reply-To email headers#137201
bitdancer merged 1 commit intopython:mainfrom
elenril:email_references

Conversation

@elenril
Copy link
Contributor

@elenril elenril commented Jul 29, 2025 •
edited by bedevere-app bot
Loading

This is a followup to 46d88a1 (#13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.

@elenril elenril requested a review from a team as a code owner July 29, 2025 09:41
@bedevere-app bedevere-app bot mentioned this pull request Jul 29, 2025
Closed
@elenril
Copy link
Contributor Author

elenril commented Aug 28, 2025

Ping, a review would be appreciated.

@elenril
Copy link
Contributor Author

elenril commented Dec 9, 2025

Ping again.

bitdancer
bitdancer requested changes Dec 10, 2025
View reviewed changes
Copy link
Member

@bitdancer bitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I have a few style comments and one logic change request.

Misc/NEWS.d/next/Library/2025-07-29-11-37-22.gh-issue-79986.fnJbE_.rst Outdated
@@ -0,0 +1,2 @@
Add parsing for References/In-Reply-To email headers, preventing them from
being folded.
Copy link
Member

@bitdancer bitdancer Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Add parsing for References and In-Reply-To headers to the :mod:email library that parses the header content as lists of message id tokens. This prevents them from being folded incorrectly."

(I'd love to add support for MessageID objects (like Address objects) an an 'ids' attribute to the headers, but that's a much bigger task and not the focus of this PR.)

Copy link
Contributor Author

@elenril elenril Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, and I actually considered doing that, but decided to fix the invalid behaviour first.

Copy link
Member

@bitdancer bitdancer Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice: that will be a new feature while this will be a bug fix and backported unless someone objects.

@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@elenril elenril force-pushed the email_references branch 2 times, most recently from a1fb731 to c474293 Compare December 11, 2025 10:15
@elenril
pythongh-79986: Add parsing for References/In-Reply-To email headers
8abd6fc 
This is a followup to 46d88a1 (python#13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.
@elenril
Copy link
Contributor Author

elenril commented Dec 11, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2025

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from bitdancer December 11, 2025 10:37
bitdancer
bitdancer approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@bitdancer bitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitdancer bitdancer merged commit 79aa43a into python:main Dec 11, 2025
51 of 54 checks passed
@bitdancer bitdancer added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 11, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 11, 2025

Thanks @elenril for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 11, 2025

Thanks @elenril for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2025
@elenril @miss-islington
pythongh-79986: Add parsing for References/In-Reply-To email headers (p…
695c430 
…ythonGH-137201)

This is a followup to 46d88a1 (pythonGH-13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.
(cherry picked from commit 79aa43a)

Co-authored-by: elenril <anton@khirnov.net>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2025
@elenril @miss-islington
pythongh-79986: Add parsing for References/In-Reply-To email headers (p…
44c366c 
…ythonGH-137201)

This is a followup to 46d88a1 (pythonGH-13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.
(cherry picked from commit 79aa43a)

Co-authored-by: elenril <anton@khirnov.net>
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2025

GH-142573 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 11, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2025

GH-142574 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2025
@elenril elenril deleted the email_references branch December 12, 2025 08:45
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 12, 2025
@elenril @fatelei
pythongh-79986: Add parsing for References/In-Reply-To email headers (p…
171261e 
…ython#137201)

This is a followup to 46d88a1 (python#13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.
bitdancer pushed a commit that referenced this pull request Dec 21, 2025
@miss-islington @elenril
[3.14] gh-79986: Add parsing for References/In-Reply-To email headers (…
4646ddc 
…GH-137201) (#142573)

gh-79986: Add parsing for References/In-Reply-To email headers (GH-137201)

This is a followup to 46d88a1 (GH-13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.
(cherry picked from commit 79aa43a)

Co-authored-by: elenril <anton@khirnov.net>
bitdancer pushed a commit that referenced this pull request Dec 21, 2025
@miss-islington @elenril
[3.13] gh-79986: Add parsing for References/In-Reply-To email headers (…
c084a66 
…GH-137201) (#142574)

gh-79986: Add parsing for References/In-Reply-To email headers (GH-137201)

This is a followup to 46d88a1 (GH-13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.
(cherry picked from commit 79aa43a)

Co-authored-by: elenril <anton@khirnov.net>
@bedevere-bot
Copy link

bedevere-bot commented Dec 21, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Refleaks 3.14 (tier-3) has failed when building commit 4646ddc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1776/builds/766) and take a look at the build logs.
  4. Check if the failure is related to this commit (4646ddc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1776/builds/766

Failed tests:

  • test_external_inspection

Failed subtests:

  • test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread
  • test_repl_eio - test.test_pyrepl.test_unix_console.TestUnixConsoleEIOHandling.test_repl_eio

Test leaking resources:

  • test_import: references
  • test_import: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs 
TracebackTests.test_import_bug) ... ok


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_pyrepl/test_unix_console.py", line 376, in test_repl_eio
    _, err = proc.communicate(timeout=support.LONG_TIMEOUT)
             ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/subprocess.py", line 1220, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/subprocess.py", line 2153, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/subprocess.py", line 1267, in _check_timeout
    raise TimeoutExpired(
    ...<2 lines>...
            stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '['/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/python', '-E', '-S', '/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_pyrepl/eio_test_script.py']' timed out after 675.0 seconds


TracebackTests.test_broken_parent_from) ... ok


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/subprocess.py", line 1138, in __del__
    _warn("subprocess %s is still running" % self.pid,
ResourceWarning: subprocess 2717333 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/unittest/case.py", line 668, in run
    with outcome.testPartExecutor(self):
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='UTF-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/unittest/case.py", line 668, in run
    with outcome.testPartExecutor(self):
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='UTF-8'>


TracebackTests.test_syntax_error) ... ok


TracebackTests.test_exec_failure_nested) ... ok


TracebackTests.test_unencodable_filename) ... ok


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_external_inspection.py", line 1246, in test_only_active_thread
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        len(gil_traces), 1, "Should have exactly one GIL holder"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 0 != 1 : Should have exactly one GIL holder


TracebackTests.test_exec_failure) ... ok


TracebackTests.test_broken_parent) ... ok


TracebackTests.test_nonexistent_module_nested) ... ok


TracebackTests.test_broken_from) ... ok


TracebackTests.test_nonexistent_module) ... ok


TracebackTests.test_broken_submodule) ... ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elenril @bedevere-bot @bitdancer
X Tutup