gh-81325: tarfile should accept a path-like object when writing a compressed gzip by aeurielesn · Pull Request #137188 · python/cpython

aeurielesn · 2025-07-28T21:20:12Z

Issue: tarfile.open: improper handling of path-like object #81325

… a compressed gzip

Misc/NEWS.d/next/Library/2025-07-28-23-11-29.gh-issue-81325.jMJFBe.rst

emmatyping

One suggestion for the news entry, but otherwise looks good!

…JFBe.rst Co-authored-by: Emma Smith <emma@emmatyping.dev>

miss-islington-app · 2025-08-04T02:53:04Z

Thanks @aeurielesn for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…honGH-137188) (cherry picked from commit 3ec3d05) Co-authored-by: Alexander Urieles <aeurielesn@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>

bedevere-app · 2025-08-04T02:53:15Z

GH-137365 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-08-04T02:53:20Z

GH-137366 is a backport of this pull request to the 3.13 branch.

bedevere-bot · 2025-08-04T03:13:55Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 3ec3d05.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/6391) and take a look at the build logs.
Check if the failure is related to this commit (3ec3d05) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/6391

Failed tests:

test_launcher

Failed subtests:

test_virtualenv_with_env - test.test_launcher.TestLauncher.test_virtualenv_with_env
tearDownClass - test.test_launcher.TestLauncher
test_search_path - test.test_launcher.TestLauncher.test_search_path
test_search_major_2 - test.test_launcher.TestLauncher.test_search_major_2
test_py_default - test.test_launcher.TestLauncher.test_py_default
test_recursive_search_path - test.test_launcher.TestLauncher.test_recursive_search_path
test_search_path_exe - test.test_launcher.TestLauncher.test_search_path_exe
test_search_major_3 - test.test_launcher.TestLauncher.test_search_major_3
test_py2_shebang_nl - test.test_launcher.TestLauncher.test_py2_shebang_nl
test_python_shebang - test.test_launcher.TestLauncher.test_python_shebang
test_shebang_command_in_venv - test.test_launcher.TestLauncher.test_shebang_command_in_venv

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 465, in test_search_major_2
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 676, in test_search_path_exe
    data = self.run_py(
        [script, "-postarg"],
        env={"PATH": f"{exe.parent};{os.getenv('PATH')}"},
    )
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 606, in test_py2_shebang_nl
    data = self.run_py([script, "-postarg"])
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 552, in test_virtualenv_with_env
    data2 = self.run_py(["-V:PythonTestSuite/3"], env={**env, "PY_PYTHON": "PythonTestSuite/3"})
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 571, in test_python_shebang
    data = self.run_py([script, "-postarg"])
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 309, in tearDownClass
    delete_registry_data(key, TEST_DATA)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 129, in delete_registry_data
    with winreg.OpenKey(root, key, access=ACCESS) as hkey:
         ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 471, in test_py_default
    self.assertEqual("PythonTestSuite", data["SearchInfo.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonTestSuite' != '(null)'
- PythonTestSuite
+ (null)


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 787, in test_shebang_command_in_venv
    data = self.run_py([script], env=env)
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 662, in test_search_path
    data = self.run_py(
        [script, "-postarg"],
        env={"PATH": f"{exe.parent};{os.getenv('PATH')}"},
    )
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 687, in test_recursive_search_path
    data = self.run_py(
        [script],
        env={"PATH": f"{self.get_py_exe().parent};{os.getenv('PATH')}"},
    )
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 254, in run_py
    self.assertEqual(expect_returncode, p.returncode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 103


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_launcher.py", line 445, in test_search_major_3
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite

…-137188) (#137366) Co-authored-by: Alexander Urieles <aeurielesn@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>

…hon#137188) Co-authored-by: Emma Smith <emma@emmatyping.dev>

…-137188) (#137365) gh-81325: Support path-like objects with streaming TarFile (GH-137188) (cherry picked from commit 3ec3d05) Co-authored-by: Alexander Urieles <aeurielesn@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>

aeurielesn added 4 commits July 28, 2025 23:06

pythongh-81325: tarfile should accept a path-like object when writing…

98fccf5

… a compressed gzip

Blurb

54d7e1a

Tests

ffbda41

Lint

a08cbdd

aeurielesn requested a review from ethanfurman as a code owner July 28, 2025 21:20

bedevere-app bot added the awaiting review label Jul 28, 2025

bedevere-app bot mentioned this pull request Jul 28, 2025

tarfile.open: improper handling of path-like object #81325

Closed

brianschubert added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 28, 2025

ethanfurman approved these changes Jul 29, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jul 29, 2025

emmatyping reviewed Aug 1, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-07-28-23-11-29.gh-issue-81325.jMJFBe.rst Outdated Show resolved Hide resolved

emmatyping approved these changes Aug 1, 2025

View reviewed changes

aeurielesn and others added 2 commits August 1, 2025 21:41

Update Misc/NEWS.d/next/Library/2025-07-28-23-11-29.gh-issue-81325.jM…

d17ff1d

…JFBe.rst Co-authored-by: Emma Smith <emma@emmatyping.dev>

NEWS

06104ec

emmatyping merged commit 3ec3d05 into python:main Aug 4, 2025
41 checks passed

bedevere-app bot removed the awaiting merge label Aug 4, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 4, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 4, 2025

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025

pythongh-81325: Support path-like objects with streaming TarFile (pyt…

21ee404

…hon#137188) Co-authored-by: Emma Smith <emma@emmatyping.dev>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-81325: tarfile should accept a path-like object when writing a compressed gzip#137188

gh-81325: tarfile should accept a path-like object when writing a compressed gzip#137188
emmatyping merged 6 commits intopython:mainfrom
aeurielesn:gh-81325

aeurielesn commented Jul 28, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

Uh oh!

emmatyping left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Aug 4, 2025

Uh oh!

bedevere-app bot commented Aug 4, 2025

Uh oh!

bedevere-app bot commented Aug 4, 2025

Uh oh!

bedevere-bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aeurielesn commented Jul 28, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

emmatyping left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Aug 4, 2025

Uh oh!

bedevere-app bot commented Aug 4, 2025

Uh oh!

bedevere-app bot commented Aug 4, 2025

Uh oh!

bedevere-bot commented Aug 4, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aeurielesn commented Jul 28, 2025 •

edited by bedevere-app bot

Loading