gh-135543: emit ``sys.remote_exec`` audit event when ``sys.remote_exec`` has been called by Zheaoli · Pull Request #135544 · python/cpython

Zheaoli · 2025-06-15T18:32:36Z

Fix #135543

Issue: Add new audit event for sys.remote_exec() #135543

📚 Documentation preview 📚: https://cpython-previews--135544.org.readthedocs.build/

…c has been called Signed-off-by: Manjusaka <me@manjusaka.me>

Signed-off-by: Manjusaka <me@manjusaka.me>

Lib/test/test_sys.py

Signed-off-by: Manjusaka <me@manjusaka.me>

Lib/test/test_sys.py

Doc/library/sys.rst

Misc/NEWS.d/next/Core_and_Builtins/2025-06-16-02-31-42.gh-issue-135543.6b0HOF.rst

Co-authored-by: Victor Stinner <vstinner@python.org>

…e-135543.6b0HOF.rst Co-authored-by: Victor Stinner <vstinner@python.org>

Signed-off-by: Manjusaka <me@manjusaka.me>

… manjusaka/fix135543

Zheaoli · 2025-06-16T19:52:16Z

@vstinner @sobolevn @pablogsal I have updated the test. PTAL when you got time

Lib/test/audit-tests.py

Lib/test/test_audit.py

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli · 2025-06-17T15:20:43Z

@vstinner I have fix the review idea. PTAL when you got time. BTW https://github.com/python/cpython/actions/runs/15710806342/job/44268135397?pr=135544 seems unrelated failed. Would you mind rerunning it for me?

vstinner

Thanks for the update, I like the updated code. Another review.

Lib/test/audit-tests.py

Lib/test/support/__init__.py

Lib/test/test_audit.py

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner

LGTM.

@pablogsal: what do you think?

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli · 2025-06-18T10:41:15Z

@vstinner sorry about this, I update a little bit of code. PTAL

Signed-off-by: Manjusaka <me@manjusaka.me>

Python/sysmodule.c

Signed-off-by: Manjusaka <me@manjusaka.me>

pablogsal · 2025-06-18T18:46:56Z

LGTM.

@pablogsal: what do you think?

I am ok with this 👍

Doc/library/sys.rst

Lib/test/audit-tests.py

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli · 2025-06-19T18:06:28Z

@zooba I have updated my PR. PTAL

zooba · 2025-06-19T20:23:10Z

LGTM, and I don't think the changes are significant since others signed off, so I'll merge.

miss-islington-app · 2025-06-19T20:24:12Z

Thanks @Zheaoli for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…c is called (pythonGH-135544) (cherry picked from commit 1ddfe59) Co-authored-by: Nadeshiko Manju <me@manjusaka.me>

bedevere-app · 2025-06-19T20:24:21Z

GH-135732 is a backport of this pull request to the 3.14 branch.

…alled (GH-135544) (cherry picked from commit 1ddfe59) Co-authored-by: Nadeshiko Manju <me@manjusaka.me>

…c is called (pythonGH-135544)

Zheaoli added 2 commits June 16, 2025 02:31

pythongh-135543: emit sys.remote_exec audit event when sys.remote_exe…

b125c78

…c has been called Signed-off-by: Manjusaka <me@manjusaka.me>

add news

afab662

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli requested a review from ericsnowcurrently as a code owner June 15, 2025 18:32

bedevere-app bot added the awaiting review label Jun 15, 2025

bedevere-app bot mentioned this pull request Jun 15, 2025

Add new audit event for sys.remote_exec() #135543

Closed

Zheaoli mentioned this pull request Jun 15, 2025

gh-135361: update documentation for remote_debugger_script audit event #135362

Merged

pablogsal reviewed Jun 15, 2025

View reviewed changes

Lib/test/test_sys.py Outdated Show resolved Hide resolved

Zheaoli added 2 commits June 16, 2025 03:09

fix code

31c6575

Signed-off-by: Manjusaka <me@manjusaka.me>

Merge main

22207f1

Signed-off-by: Manjusaka <me@manjusaka.me>

sobolevn reviewed Jun 15, 2025

View reviewed changes

Lib/test/test_sys.py Outdated Show resolved Hide resolved

vstinner reviewed Jun 16, 2025

View reviewed changes

Lib/test/test_sys.py Outdated Show resolved Hide resolved

Doc/library/sys.rst Outdated Show resolved Hide resolved

Doc/library/sys.rst Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Core_and_Builtins/2025-06-16-02-31-42.gh-issue-135543.6b0HOF.rst Outdated Show resolved Hide resolved

Zheaoli and others added 7 commits June 17, 2025 03:06

Update Doc/library/sys.rst

55e3470

Co-authored-by: Victor Stinner <vstinner@python.org>

Update Doc/library/sys.rst

e3fd3ca

Co-authored-by: Victor Stinner <vstinner@python.org>

Update Misc/NEWS.d/next/Core_and_Builtins/2025-06-16-02-31-42.gh-issu…

732e3fd

…e-135543.6b0HOF.rst Co-authored-by: Victor Stinner <vstinner@python.org>

fix review idea

daed532

Signed-off-by: Manjusaka <me@manjusaka.me>

Merge branch 'main' into manjusaka/fix135543

183387a

update test

f1c6f03

Signed-off-by: Manjusaka <me@manjusaka.me>

Merge branch 'manjusaka/fix135543' of github.com:Zheaoli/cpython into…

baa0032

… manjusaka/fix135543

Zheaoli requested review from pablogsal, sobolevn and vstinner June 16, 2025 19:51

vstinner reviewed Jun 17, 2025

View reviewed changes

Lib/test/audit-tests.py Outdated Show resolved Hide resolved

Lib/test/audit-tests.py Outdated Show resolved Hide resolved

Lib/test/audit-tests.py Outdated Show resolved Hide resolved

Lib/test/test_audit.py Outdated Show resolved Hide resolved

Lib/test/test_audit.py Show resolved Hide resolved

Zheaoli added 3 commits June 17, 2025 22:44

Fix review idea

b9bc94e

Signed-off-by: Manjusaka <me@manjusaka.me>

Fix review idea

b158a2b

Signed-off-by: Manjusaka <me@manjusaka.me>

Fix review idea

2394b27

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli requested a review from vstinner June 17, 2025 15:21

vstinner reviewed Jun 17, 2025

View reviewed changes

Lib/test/audit-tests.py Outdated Show resolved Hide resolved

Lib/test/support/__init__.py Outdated Show resolved Hide resolved

Lib/test/support/__init__.py Outdated Show resolved Hide resolved

Lib/test/test_audit.py Show resolved Hide resolved

Update Lib/test/support/__init__.py

9302ef3

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner approved these changes Jun 18, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jun 18, 2025

Update code

2fcb502

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli added 2 commits June 18, 2025 22:38

Update code

6561e81

Signed-off-by: Manjusaka <me@manjusaka.me>

Update code

4e7c384

Signed-off-by: Manjusaka <me@manjusaka.me>

zooba reviewed Jun 18, 2025

View reviewed changes

Python/sysmodule.c Outdated Show resolved Hide resolved

Zheaoli added 2 commits June 19, 2025 02:42

fix review idea

20ac399

Signed-off-by: Manjusaka <me@manjusaka.me>

update news

8682689

Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli requested a review from zooba June 18, 2025 18:44

zooba reviewed Jun 18, 2025

View reviewed changes

Doc/library/sys.rst Outdated Show resolved Hide resolved

Doc/library/sys.rst Show resolved Hide resolved

Lib/test/audit-tests.py Outdated Show resolved Hide resolved

Lib/test/audit-tests.py Outdated Show resolved Hide resolved

fix review idea

60725af

Signed-off-by: Manjusaka <me@manjusaka.me>

ericsnowcurrently removed their request for review June 19, 2025 15:00

zooba merged commit 1ddfe59 into python:main Jun 19, 2025
40 checks passed

bedevere-app bot removed the awaiting merge label Jun 19, 2025

zooba added the needs backport to 3.14 bugs and security fixes label Jun 19, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 19, 2025

zooba pushed a commit that referenced this pull request Jun 19, 2025

gh-135543: Emit sys.remote_exec audit event when sys.remote_exec is c…

0370cb4

…alled (GH-135544) (cherry picked from commit 1ddfe59) Co-authored-by: Nadeshiko Manju <me@manjusaka.me>

lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025

pythongh-135543: Emit sys.remote_exec audit event when sys.remote_exe…

b1ac1d6

…c is called (pythonGH-135544)

Zheaoli deleted the manjusaka/fix135543 branch June 19, 2025 21:53

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-135543: Emit sys.remote_exec audit event when sys.remote_exe…

72a1156

…c is called (pythonGH-135544)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-135543: Emit sys.remote_exec audit event when sys.remote_exe…

89a5f4d

…c is called (pythonGH-135544)

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025

pythongh-135543: Emit sys.remote_exec audit event when sys.remote_exe…

d59d877

…c is called (pythonGH-135544)

Uh oh!

Conversation

Zheaoli commented Jun 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zheaoli commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zheaoli commented Jun 17, 2025

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Zheaoli commented Jun 18, 2025

Uh oh!

Uh oh!

pablogsal commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zheaoli commented Jun 19, 2025

Uh oh!

zooba commented Jun 19, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jun 19, 2025

Uh oh!

bedevere-app bot commented Jun 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zheaoli commented Jun 15, 2025 •

edited by github-actions bot

Loading