gh-135361: update documentation for remote_debugger_script audit event#135362
gh-135361: update documentation for remote_debugger_script audit event#135362pablogsal merged 5 commits intopython:mainfrom
remote_debugger_script audit event#135362Conversation
…t event Signed-off-by: Manjusaka <me@manjusaka.me>
bedevere-app
bot
added
awaiting review
docs
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM
The audit event is logged in Python/ceval_gil.c:
static inline void run_remote_debugger_script(PyObject *path)
{
if (0 != PySys_Audit("remote_debugger_script", "O", path)) {
PyErr_FormatUnraisable(
"Audit hook failed for remote debugger script %U", path);
return;
}
...
|
cc @pablogsal |
vstinner
dismissed
their stale review
I misunderstood the audit event. It's recorded by the debugged process. The documentation should clarify that.
| @@ -1933,6 +1933,8 @@ always available. Unless explicitly noted otherwise, all variables are read-only | |||
| interpreter is pre-release (alpha, beta, or release candidate) then the | |||
| local and remote interpreters must be the same exact version. | |||
|
|
|||
There was a problem hiding this comment.
I misunderstood the audit event. It's recorded by the debugged process. The documentation should clarify that.
Or maybe the audit event should also be logged by the process which calls sys.remote_exec().
There was a problem hiding this comment.
I can update and add more info, BTW I think we can logged the event at both side
There was a problem hiding this comment.
I think we should get an audit event in sys.remote_exec() yes
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
…manjusaka/gh135361
|
I think this PR can be merged first. I open another PR for debugger side event #135544 |
|
Thanks @Zheaoli for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…dit event (pythonGH-135362) (cherry picked from commit 076f874) Co-authored-by: Nadeshiko Manju <me@manjusaka.me>
|
GH-135546 is a backport of this pull request to the 3.14 branch. |
|
Thanks for the contribution 🤘 |
4 participants
Fix #135361
remote_debugger_scriptaudit event in doc #135361