X Tutup
Skip to content

gh-134908: protect textiowrapper_iternext with critical section #134910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 8 commits into from
Jun 2, 2025
Merged

gh-134908: protect textiowrapper_iternext with critical section #134910

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
588a5b6
gh-134908: protect ``textiowrapper_iternext`` with critical section
duaneg May 30, 2025
25e5572
Address review feedback (thanks!)
duaneg May 30, 2025
84e8537
Update Misc/NEWS.d/next/Core_and_Builtins/2025-05-30-15-56-19.gh-issu…
duaneg May 30, 2025
aebcc98
Update Modules/_io/textio.c
duaneg Jun 1, 2025
72d1f9d
Update Modules/_io/textio.c
duaneg Jun 1, 2025
ad17efb
More improvements after review feedback
duaneg Jun 1, 2025
ee6ef44
Apply suggestions from code review
colesbury Jun 2, 2025
c15ea28
Make test a bit faster on the GIL-enabled build
colesbury Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Misc/NEWS.d/next/Core_and_Builtins/2025-05-30-15-56-19.gh-issu… 
…e-134908.3a7PxM.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
  • Loading branch information
@duaneg @ZeroIntensity
duaneg and ZeroIntensity authored May 30, 2025
commit 84e853712e6b0bb9db501d510928d059cde63fcd
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core_and_Builtins/2025-05-30-15-56-19.gh-issue-134908.3a7PxM.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Make iterating over lines in a text file thread safe in free threading.
Fix crash when iterating over lines in a text file thread safe on the :term:`free threaded <free threading>` build.
Loading
X Tutup