X Tutup
Skip to content

gh-134696: align OpenSSL and HACL*-based hash functions constructors AC signatures #134713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 14 commits into from
May 31, 2025
Merged

gh-134696: align OpenSSL and HACL*-based hash functions constructors AC signatures #134713

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
996d232
align clinic signatures of HACL* hash functions with OpenSSL ones
picnixz May 26, 2025
b35ce61
Merge remote-tracking branch 'upstream/main' into fix/shake/hacl-impl…
picnixz May 26, 2025
679f811
ensure backward compatibility
picnixz May 27, 2025
569d63e
Update Lib/hashlib.py
picnixz May 27, 2025
1699b91
remove impossible paths
picnixz May 27, 2025
a6f8ee7
Handle more ambiguous cases
picnixz May 27, 2025
f68ea02
Update Lib/test/test_hashlib.py
picnixz May 27, 2025
0724bdd
Update Lib/hashlib.py
picnixz May 27, 2025
18de16e
Update Lib/hashlib.py
picnixz May 27, 2025
fdc384b
Update Lib/test/test_hashlib.py
picnixz May 27, 2025
bcd6d4d
fix tests
picnixz May 27, 2025
6628603
Merge branch 'fix/shake/hacl-implementation-clinic-134696' of github.…
picnixz May 30, 2025
70aab73
simplify implementations
picnixz May 28, 2025
5a88d88
Merge branch 'main' into fix/shake/hacl-implementation-clinic-134696
picnixz May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@picnixz
picnixz authored May 27, 2025
commit bcd6d4d3de24540299419ae5d3aca975cf84d1cf
4 changes: 4 additions & 0 deletions Lib/test/test_hashlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,10 @@ def test_clinic_signature_errors(self):
"is slated for removal in a future version."
)
duplicated_param = re.escape("given by name ('data') and position")
# Depending on whether we call hashlib.__py_new, hashlib.__hash_new,
# or _hashlib.new(), we have different errors as the C implementation
# does not need an additional sentinel.
duplicated_param = f"{conflicting_call}|{duplicated_param}"
for constructor in self.hash_constructors:
with self.subTest(constructor.__name__):
with self.assertRaisesRegex(TypeError, conflicting_call):
Expand Down
Loading
X Tutup