X Tutup
Skip to content

gh-133744: Fix multiprocessing interrupt test: add an event#133746

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:mp_interrupt
May 12, 2025
Merged

gh-133744: Fix multiprocessing interrupt test: add an event#133746
vstinner merged 1 commit intopython:mainfrom
vstinner:mp_interrupt

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented May 9, 2025 •
edited by bedevere-app bot
Loading

Add an event to synchronize the parent process with the child process: wait until the child process starts sleeping.

@vstinner
pythongh-133744: Fix multiprocessing interrupt test: add an event
83ee464 
Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.
@vstinner vstinner added tests Tests in the Lib/test dir topic-multiprocessing labels May 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2025
Closed
@vstinner vstinner marked this pull request as ready for review May 9, 2025 12:56
@vstinner vstinner requested a review from gpshead as a code owner May 9, 2025 12:56
@vstinner
Copy link
Member Author

vstinner commented May 9, 2025

cc @gpshead @colesbury @pitrou

Without this change, the SIGINT signal can be sent too early: in multiprocessing setup code.

@vstinner
Copy link
Member Author

vstinner commented May 9, 2025

With this change, I can no longer reproduce the issue:

$ ./python -m test test_multiprocessing_spawn.test_processes -m test_interrupt_no_handler -m test_interrupt -m test_terminate -m test_kill  -W -F -j14
...
0:02:04 load avg: 17.62 [180] test_multiprocessing_spawn.test_processes passed
0:02:04 load avg: 18.13 [181] test_multiprocessing_spawn.test_processes passed
0:02:06 load avg: 18.13 [182] test_multiprocessing_spawn.test_processes passed

@vstinner
Copy link
Member Author

vstinner commented May 9, 2025

Since 2013, there was a workaround for this issue, using a simple sleep(1): commit 26f9268.

        # XXX maybe terminating too soon causes the problems on Gentoo...
        time.sleep(1)

@vstinner vstinner merged commit c2989b7 into python:main May 12, 2025
45 checks passed
@vstinner vstinner deleted the mp_interrupt branch May 12, 2025 09:10
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 12, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented May 12, 2025

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented May 12, 2025

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented May 12, 2025

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c2989b7070b18c0b7c51521fed8bc11c159ea5b8 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@vstinner @miss-islington
pythongh-133744: Fix multiprocessing interrupt test: add an event (py…
491ba18 
…thonGH-133746)

Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.
(cherry picked from commit c2989b7)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133916 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133917 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 12, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request May 12, 2025
@vstinner
pythongh-133744: Fix multiprocessing interrupt test: add an event (py…
b523a6a 
…thon#133746)

Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.

(cherry picked from commit c2989b7)
vstinner added a commit that referenced this pull request May 12, 2025
@miss-islington @vstinner
[3.14] gh-133744: Fix multiprocessing interrupt test: add an event (G…
f5d2d73 
…H-133746) (#133916)

gh-133744: Fix multiprocessing interrupt test: add an event (GH-133746)

Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.
(cherry picked from commit c2989b7)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request May 12, 2025
@vstinner
[3.13] gh-133744: Fix multiprocessing interrupt test: add an event (#…
5ce47b9 
…133746) (#133917)

gh-133744: Fix multiprocessing interrupt test: add an event (#133746)

Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.

(cherry picked from commit c2989b7)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@vstinner @Pranjal095
pythongh-133744: Fix multiprocessing interrupt test: add an event (py…
b594cf2 
…thon#133746)

Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@vstinner @taegyunkim
pythongh-133744: Fix multiprocessing interrupt test: add an event (py…
47fc3c5 
…thon#133746)

Add an event to synchronize the parent process with the child
process: wait until the child process starts sleeping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

@vstinner vstinner

Labels

tests Tests in the Lib/test dir topic-multiprocessing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner
X Tutup