X Tutup
Skip to content

Fix inconsistent set ordering in annotations (GH-133682)#133702

Merged
JelleZijlstra merged 15 commits intopython:mainfrom
akshat62:issue-133682-fix-set-ordering
May 9, 2025
Merged

Fix inconsistent set ordering in annotations (GH-133682)#133702
JelleZijlstra merged 15 commits intopython:mainfrom
akshat62:issue-133682-fix-set-ordering

Conversation

@akshat62
Copy link
Contributor

@akshat62 akshat62 commented May 8, 2025 •
edited by bedevere-app bot
Loading

@akshat62 akshat62 requested a review from JelleZijlstra as a code owner May 8, 2025 19:14
@python-cla-bot
Copy link

python-cla-bot bot commented May 8, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request May 8, 2025
Closed
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@akshat62 akshat62 marked this pull request as draft May 8, 2025 19:22
@akshat62 akshat62 marked this pull request as ready for review May 8, 2025 19:33
terryjreedy
terryjreedy reviewed May 8, 2025
View reviewed changes
@akshat62 akshat62 force-pushed the issue-133682-fix-set-ordering branch from 0502f3e to c952b12 Compare May 8, 2025 19:47
@akshat62 akshat62 marked this pull request as draft May 8, 2025 19:51
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@akshat62 akshat62 marked this pull request as ready for review May 8, 2025 20:09
@akshat62 akshat62 requested a review from terryjreedy May 8, 2025 20:10
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@akshat62
Copy link
Contributor Author

akshat62 commented May 9, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented May 9, 2025

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from JelleZijlstra May 9, 2025 04:11
@methane methane removed their request for review May 9, 2025 04:14
@akshat62
Copy link
Contributor Author

akshat62 commented May 9, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented May 9, 2025

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

@akshat62
Copy link
Contributor Author

akshat62 commented May 9, 2025

How to re-trigger failing checks ?

@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label May 9, 2025
@JelleZijlstra JelleZijlstra merged commit a2a0fa9 into python:main May 9, 2025
44 of 45 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented May 9, 2025

Thanks @akshat62 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2025
@akshat62 @miss-islington
pythongh-133682: Fix inconsistent set ordering in annotationlib test (p…
0abf4ea 
…ythonGH-133702)

(cherry picked from commit a2a0fa9)

Co-authored-by: Akshat Gupta <akshat.gupta24@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2025

GH-133754 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 9, 2025
JelleZijlstra pushed a commit that referenced this pull request May 9, 2025
@miss-islington @akshat62
[3.14] gh-133682: Fix inconsistent set ordering in annotationlib test (…
52d89f5 
…GH-133702) (#133754)

gh-133682: Fix inconsistent set ordering in annotationlib test (GH-133702)
(cherry picked from commit a2a0fa9)

Co-authored-by: Akshat Gupta <akshat.gupta24@gmail.com>
@akshat62 akshat62 deleted the issue-133682-fix-set-ordering branch May 9, 2025 16:53
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@akshat62 @Pranjal095
pythongh-133682: Fix inconsistent set ordering in annotationlib test (p…
3c9ec50 
…ython#133702)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@akshat62 @taegyunkim
pythongh-133682: Fix inconsistent set ordering in annotationlib test (p…
e6da3f4 
…ython#133702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@pfmoore pfmoore Awaiting requested review from pfmoore

@pradyunsg pradyunsg Awaiting requested review from pradyunsg

@markshannon markshannon Awaiting requested review from markshannon

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

@hugovk hugovk Awaiting requested review from hugovk

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akshat62 @JelleZijlstra @terryjreedy
X Tutup