GH-108819: fix LIBDEST not honoring --with-platlibdir#133163
GH-108819: fix LIBDEST not honoring --with-platlibdir#133163FFY00 merged 5 commits intopython:mainfrom
Conversation
We look for the pure-Python part of the standard library in
PLATSTDLIBDIR, which may not match the default LIBDIR subdir.
From ``getpath.py``:
```python
...
STDLIB_SUBDIR = f'{platlibdir}/python{VERSION_MAJOR}.{VERSION_MINOR}{ABI_THREAD}'
STDLIB_LANDMARKS = [f'{STDLIB_SUBDIR}/os.py', f'{STDLIB_SUBDIR}/os.pyc']
PLATSTDLIB_LANDMARK = f'{platlibdir}/python{VERSION_MAJOR}.{VERSION_MINOR}{ABI_THREAD}/lib-dynload'
...
```
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
@tfpf, can you test? |
|
Note: Since this fix changes the pure-Python standard library installation path, it shouldn't be backported. |
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
We could fix old versions by patching Alternatively, we could simply detect such cases, emmit a build warning, and maybe install a symlink to make |
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
🤖 New build scheduled with the buildbot fleet by @FFY00 for commit a2b43c9 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133163%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
I no longer have access to the openSUSE Tumbleweed installation on which I first found this issue, so I used Docker, as I have documented in the linked issue. I think it worked! But there's a different (possibly unrelated) error about
|
|
GIven the feedback, and also because this is still an issue with |
We look for the pure-Python part of the standard library in PLATSTDLIBDIR, which may not match the default LIBDIR subdir.
From
getpath.py:... STDLIB_SUBDIR = f'{platlibdir}/python{VERSION_MAJOR}.{VERSION_MINOR}{ABI_THREAD}' STDLIB_LANDMARKS = [f'{STDLIB_SUBDIR}/os.py', f'{STDLIB_SUBDIR}/os.pyc'] PLATSTDLIB_LANDMARK = f'{platlibdir}/python{VERSION_MAJOR}.{VERSION_MINOR}{ABI_THREAD}/lib-dynload' ...lib-dynloadinstalled in wrong location on a 64-bit system whenCONFIG_SITEis set #108819