gh-132710: only use stable _uuid.generate_time_safe() to deduce MAC address#132901
gh-132710: only use stable _uuid.generate_time_safe() to deduce MAC address#132901picnixz merged 9 commits intopython:mainfrom
_uuid.generate_time_safe() to deduce MAC address#132901Conversation
|
cc @zanieb |
2d398c9 to
99bdd52
Compare
99bdd52 to
ee71d62
Compare
|
@zanieb Does it actually solve your issue? because my system also appears to be unable to get the MAC address... but I was offline (I work offline during the week in general) and I didn't check when I'm online. |
|
It's kind of hard to test because I haven't added support for the latest 3.14 in |
|
Okay, the patch does apply cleanly to the previous 3.14 alpha so I can test this. On macOS, it does resolve the problem. I did not test Linux. |
|
I tested a Linux build at astral-sh/python-build-standalone#595 (comment) and it didn't seem to work. |
|
Hum. It's very strange. Did I mess the configure script? what's the value of |
|
Looking at the logs... |
|
... so it's not |
|
The builds are attached there if you want to hop into a debugger. Briefly... yeah it looks like it's called and we try each getter until we reach the random one: |
|
So, the patch worked but it turns out |
|
Maybe we should add all possible |
|
We did try |
|
I suggest adding a print in the |
|
Those commands are just not installed by default in the |
|
Ha! so that's why. Let's also fix this by adding them as a dependency then |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 16200ae 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132901%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Can do. The next 3.13 is scheduled for 2025-06-03. After that is 2025-08-05, by which time we'll have had all three remaining 3.14 betas and one RC. |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit fd84b3c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132901%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
Note: the buildbot failures are unrelated so I'll ignore them. |
|
Hum, is our backport bot sick? it didn't make an automatic backport, so I'll do it for 3.14 |
…to deduce MAC address (pythonGH-132901) (cherry picked from commit 3bffada) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @picnixz, I could not cleanly backport this to |
|
huh... ok I'll make the manual bp, add a DO-NOT-MERGE and so that we don't forget it |
|
GH-134704 is a backport of this pull request to the 3.13 branch. |
…ce MAC address (python#132901)
…ce MAC address (python#132901)
libuuid#132710