gh-132798: Schedule removal of PyUnicode_AsDecoded/Encoded functions for 3.15#132799
Merged
vstinner merged 5 commits intopython:mainfrom Apr 25, 2025
Merged
gh-132798: Schedule removal of PyUnicode_AsDecoded/Encoded functions for 3.15#132799vstinner merged 5 commits intopython:mainfrom
PyUnicode_AsDecoded/Encoded functions for 3.15#132799vstinner merged 5 commits intopython:mainfrom
Conversation
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
These functions are in the limited API. I'm not sure what the procedure is for removing them, but they can't just disappear from the ABI. I think the practice is to remove them from headers when the limited API isn't used. We should probably make note of that somewhere.
Member
Mark them as See PyUnicode_GetSize() for an existing example. |
vstinner
reviewed
Apr 22, 2025
vstinner
reviewed
Apr 22, 2025
vstinner
reviewed
Apr 22, 2025
Member
Author
|
Anything else left to do @vstinner ? |
vstinner
reviewed
Apr 25, 2025
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--132799.org.readthedocs.build/