gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization#132018
Merged
sobolevn merged 6 commits intopython:mainfrom Apr 6, 2025
Merged
gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization#132018sobolevn merged 6 commits intopython:mainfrom
CALL_LIST_APPEND deoptimization#132018sobolevn merged 6 commits intopython:mainfrom
Conversation
Co-authored-by: Victor Stinner <vstinner@python.org>
ZeroIntensity
approved these changes
Apr 2, 2025
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM as well, with two English-related nitpicks.
Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
vstinner
reviewed
Apr 2, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst
Outdated
Show resolved
Hide resolved
…e-132011.dNh64H.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Member
Author
|
(not merging, because I am waiting for @markshannon's review as code owner) |
Member
Author
|
Going to merge soon, since I don't want to create and resolve merge conflicts on generated files. |
|
All commit authors signed the Contributor License Agreement. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @sobolevn, I could not cleanly backport this to |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Apr 6, 2025
…imization (pythonGH-132018) (cherry picked from commit c0661df) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-132161 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Apr 6, 2025
…ion (GH-132018) (#132161) * [3.13] gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization (GH-132018) (cherry picked from commit c0661df) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks similar to #132000
_PyEval_EvalFrameDefault:self_o != NULL#132011