gh-131290: ensure that test files can be executed as standalone scripts by MaximGit1 · Pull Request #131371 · python/cpython

MaximGit1 · 2025-03-17T16:31:03Z

Now tests are launched via ./python.exe and work correctly

Issue: Multiple tests failing when invoked directly via ./python Lib/test/... #131290

added environment variable value "PYTHONREGRTEST_UNICODE_GUARD0" when calling the test directly

added spec for test when calling directly

ghost · 2025-03-17T16:31:06Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-03-17T16:31:08Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2025-03-17T16:35:31Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Misc/NEWS.d/next/Tests/2025-03-17-19-47-27.gh-issue-131290.NyCIXR.rst

Lib/test/test_metaclass.py

picnixz · 2025-03-17T17:39:36Z

Lib/test/test_pyclbr.py

 if __name__ == "__main__":
+    import importlib.util
+
+    # Adding the __spec__ attribute to the __main__ module


Which test is failing because of the lack of __spec__?

test_others

user\cpython\Lib\test\test_pyclbr.py", line 226, in test_others cm( ~~^ 'pdb', ^^^^^^ # pyclbr does not handle elegantly `typing` or properties ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ignore=('Union', '_ModuleTarget', '_ScriptTarget', '_ZipTarget', 'curframe_locals'), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ) ^ File "user\cpython\Lib\test\test_pyclbr.py", line 142, in checkModule self.assertHaskey(dict, name, ignore) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^ File "user\cpython\Lib\test\test_pyclbr.py", line 39, in assertHaskey self.assertIn(key, obj) ~~~~~~~~~~~~~^^^^^^^^^^ AssertionError: 'Pdb' not found in {'contextmanager': <pyclbr.Function object at 0x000001DA2A910690>} ---------------------------------------------------------------------- Ran 6 tests in 11.022s FAILED (failures=1, errors=1)

Can you make it a local solution for Pdb then? possibly extracting this test into a separate function?

picnixz · 2025-03-17T17:42:11Z

Lib/test/test_regrtest.py

+    os.environ['PYTHONREGRTEST_UNICODE_GUARD'] = 'some_value' # for test_unicode_guard_env
    unittest.main()


Suggested change

os.environ['PYTHONREGRTEST_UNICODE_GUARD'] = 'some_value' # for test_unicode_guard_env

unittest.main()

with EnvironmentVarGuard() as env:

# for test_unicode_guard_env

PYTHONREGRTEST_UNICODE_GUARD = "some_value"

unittest.main()

and add some from test.support.os_hepler import EnvironmentVarGuard top-level import. However, I don't know if this is correct to test test_unicode_guard_env like this or if we shouldn't just skip if it we're running it from __main__. Namely, decorate the test with @unittest.skipIf(__name__ == '__main__') cc @vstinner

picnixz · 2025-03-17T17:44:18Z

The CLA needs to be signed.
The NEWS entry seems to fail but I don't know if it's because of its name or if it's because of its content.

vstinner · 2025-03-17T18:45:16Z

For regrtest, I would prefer this fix:

diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py
index 510c8f69631..7e317d5ab94 100644
--- a/Lib/test/test_regrtest.py
+++ b/Lib/test/test_regrtest.py
@@ -2546,4 +2546,5 @@ def test_test_result_get_state(self):
 
 
 if __name__ == '__main__':
+    setup.setup_process()
     unittest.main()

Lib/test/test_metaclass.py

picnixz · 2025-03-30T11:39:54Z

Lib/test/test_pyclbr.py

 if __name__ == "__main__":
+    import importlib.util
+
+    # Adding the __spec__ attribute to the __main__ module


Can you make it a local solution for Pdb then? possibly extracting this test into a separate function?

Misc/NEWS.d/next/Tests/2025-03-17-19-47-27.gh-issue-131290.NyCIXR.rst

bedevere-app · 2025-03-30T11:40:42Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Misc/NEWS.d/next/Tests/2025-04-07-13-45-23.gh-issue-131290.MaximGit1.rst

bedevere-app · 2025-04-06T22:33:46Z

Thanks for making the requested changes!

: please review the changes made to this pull request.

Lib/test/test_pyclbr.py

picnixz

I'm not on my dev session so I can't check but can you check again that the entire test suite is now correctly runnable as standalone files? TiA.

picnixz · 2025-04-07T14:52:01Z

Lib/test/test_pyclbr.py

        compare(None, actual, None, expected)

+    def test_pdb_module(self):
+        with temporary_main_spec():


With the context manager, it's maybe better to actually put this one back in test_others(). We're also already using with warnings.catch_warnings(). Sorry for this oversight!

def test_others(self): cm = ... ... with temporary_main_spec(): cm('pdb', ...)

MaximGit1 · 2025-04-07T15:49:32Z

ok i checked the tests here are the results

./python .\Lib\test\test_metaclass.py
Running Debug|x64 interpreter...
.
----------------------------------------------------------------------
Ran 1 test in 0.191s

OK

./python .\Lib\test\test_pyclbr.py
Running Debug|x64 interpreter...
......
----------------------------------------------------------------------
Ran 6 tests in 10.211s

OK

./python .\Lib\test\test_regrtest.py 
Running Debug|x64 interpreter...
...................................................................................................................
----------------------------------------------------------------------
Ran 115 tests in 242.723s

OK

Lib/test/test_pyclbr.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz · 2025-04-11T23:56:18Z

I'm sorry I forgot about this one before leaving! I'll merge this by Sunday!

MaximGit1 added 3 commits March 17, 2025 19:17

fixed test_regrtest

a9c7bc0

added environment variable value "PYTHONREGRTEST_UNICODE_GUARD0" when calling the test directly

added spec in test.test_pyclbr.py

b875bee

added spec for test when calling directly

changed module name when calling test_metaclass.py directly

678893f

bedevere-app bot added the tests Tests in the Lib/test dir label Mar 17, 2025

bedevere-app bot added the awaiting review label Mar 17, 2025

bedevere-app bot mentioned this pull request Mar 17, 2025

Multiple tests failing when invoked directly via ./python Lib/test/... #131290

Closed

Merge branch 'main' into fix-for-running-tests-issue-131290

4670696

MaximGit1 and others added 2 commits March 17, 2025 19:48

added Misc/NEWS

3241aeb

Merge branch 'main' into fix-for-running-tests-issue-131290

5ffd268

picnixz changed the title ~~gh-131290: Several tests are modified when called directly via ./python Lib/test/...~~ gh-131290: fix direct test files invocation Mar 17, 2025

picnixz added the skip news label Mar 17, 2025

sobolevn requested a review from Eclips4 March 17, 2025 17:30

picnixz reviewed Mar 17, 2025

View reviewed changes

picnixz changed the title ~~gh-131290: fix direct test files invocation~~ fix direct test files invocation Mar 17, 2025

picnixz changed the title ~~fix direct test files invocation~~ gh-131290: fix direct test files invocation Mar 17, 2025

Apply review suggestions for test_regrtest

d3cdd6b

picnixz previously requested changes Mar 30, 2025

View reviewed changes

bedevere-app bot removed the awaiting review label Mar 30, 2025

bedevere-app bot added the awaiting changes label Mar 30, 2025

picnixz removed the skip news label Mar 30, 2025

MaximGit1 added 3 commits April 6, 2025 23:46

added comment for test_metaclass.py

682613f

refactor(tests): improve structure and naming in test_pyclbr.py

22c996d

created news file

6744e91

picnixz reviewed Apr 6, 2025

View reviewed changes

Misc/NEWS.d/next/Tests/2025-04-07-13-45-23.gh-issue-131290.MaximGit1.rst Outdated Show resolved Hide resolved

bedevere-app bot added awaiting change review and removed awaiting review labels Apr 6, 2025

picnixz self-requested a review April 6, 2025 22:46

picnixz reviewed Apr 6, 2025

View reviewed changes

Lib/test/test_pyclbr.py Outdated Show resolved Hide resolved

Lib/test/test_pyclbr.py Outdated Show resolved Hide resolved

Lib/test/test_pyclbr.py Outdated Show resolved Hide resolved

Lib/test/test_pyclbr.py Outdated Show resolved Hide resolved

refactored contextmanager

2134259

picnixz reviewed Apr 7, 2025

View reviewed changes

picnixz added awaiting review and removed awaiting change review labels Apr 7, 2025

removed test_pdb_module

cd3f0bb

picnixz reviewed Apr 7, 2025

View reviewed changes

Lib/test/test_pyclbr.py Outdated Show resolved Hide resolved

changed the order of checks in the test_others function

19e1a3a

picnixz reviewed Apr 7, 2025

View reviewed changes

Lib/test/test_pyclbr.py Show resolved Hide resolved

Lib/test/test_pyclbr.py Show resolved Hide resolved

Lib/test/test_pyclbr.py Show resolved Hide resolved

added comment and ignores

d12e5c6

picnixz reviewed Apr 7, 2025

View reviewed changes

Lib/test/test_pyclbr.py Outdated Show resolved Hide resolved

Update Lib/test/test_pyclbr.py

9e28fa4

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz approved these changes Apr 7, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Apr 7, 2025

picnixz self-assigned this Apr 7, 2025

Merge branch 'main' into fix-for-running-tests-issue-131290

ca81976

picnixz enabled auto-merge (squash) April 12, 2025 07:24

picnixz disabled auto-merge April 12, 2025 07:24

picnixz enabled auto-merge (squash) April 12, 2025 07:25

picnixz changed the title ~~gh-131290: fix direct test files invocation~~ gh-131290: ensure that test files can be executed as standalone scripts Apr 12, 2025

picnixz merged commit 292a724 into python:main Apr 12, 2025
39 checks passed

bedevere-app bot removed the awaiting merge label Apr 12, 2025

donbarbos mentioned this pull request May 3, 2025

gh-131031: Fix separated running of pickle tests #133218

Closed

		os.environ['PYTHONREGRTEST_UNICODE_GUARD'] = 'some_value' # for test_unicode_guard_env
		unittest.main()

Uh oh!

Conversation

MaximGit1 commented Mar 17, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 17, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Mar 17, 2025

Uh oh!

bedevere-app bot commented Mar 17, 2025

Uh oh!

Uh oh!

Uh oh!

picnixz Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

MaximGit1 Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Mar 30, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz commented Mar 17, 2025

Uh oh!

vstinner commented Mar 17, 2025

Uh oh!

Uh oh!

picnixz Mar 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-app bot commented Mar 30, 2025

Uh oh!

Uh oh!

bedevere-app bot commented Apr 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

picnixz Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

MaximGit1 commented Apr 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz commented Apr 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MaximGit1 commented Mar 17, 2025 •

edited by bedevere-app bot

Loading

ghost commented Mar 17, 2025 •

edited by ghost

Loading