gh-130932: Fix incorrect exception handling in _PyModule_IsPossiblyShadowing#130934
Merged
hauntsaninja merged 4 commits intopython:mainfrom Mar 7, 2025
Merged
gh-130932: Fix incorrect exception handling in _PyModule_IsPossiblyShadowing#130934hauntsaninja merged 4 commits intopython:mainfrom
hauntsaninja merged 4 commits intopython:mainfrom
Conversation
…iblyShadowing I chose to not raise an exception here because I think it would be confusing for module attribute access to start raising something other than AttributeError if e.g. the cwd goes away Without the change in moduleobject.c ``` ./python.exe -m unittest test.test_import.ImportTests.test_script_shadowing_stdlib_cwd_failure ... Assertion failed: (PyErr_Occurred()), function _PyObject_SetAttributeErrorContext, file object.c, line 1253. ```
hauntsaninja
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
Contributor
|
Looks like Windows is not happy with the test trying to delete the current working directory |
colesbury
approved these changes
Mar 7, 2025
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
LGTM, assuming the CI passes
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2025
…iblyShadowing (pythonGH-130934) I chose to not raise an exception here because I think it would be confusing for module attribute access to start raising something other than AttributeError if e.g. the cwd goes away Without the change in moduleobject.c ``` ./python.exe -m unittest test.test_import.ImportTests.test_script_shadowing_stdlib_cwd_failure ... Assertion failed: (PyErr_Occurred()), function _PyObject_SetAttributeErrorContext, file object.c, line 1253. ``` (cherry picked from commit 0a9ae5e) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
GH-130939 is a backport of this pull request to the 3.13 branch. |
hauntsaninja
added a commit
that referenced
this pull request
Mar 7, 2025
…siblyShadowing (GH-130934) (#130939) gh-130932: Fix incorrect exception handling in _PyModule_IsPossiblyShadowing (GH-130934) I chose to not raise an exception here because I think it would be confusing for module attribute access to start raising something other than AttributeError if e.g. the cwd goes away Without the change in moduleobject.c ``` ./python.exe -m unittest test.test_import.ImportTests.test_script_shadowing_stdlib_cwd_failure ... Assertion failed: (PyErr_Occurred()), function _PyObject_SetAttributeErrorContext, file object.c, line 1253. ``` (cherry picked from commit 0a9ae5e) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change in moduleobject.c, we sometimes end up returning NULL from
_Py_module_getattro_implwithout an exception raised.I chose to not raise an exception here because I think it would be confusing for module attribute access to start raising something other than AttributeError if e.g. the cwd goes away
_PyModule_IsPossiblyShadowingcan return-1without an exception set #130932