gh-110067: Make max heap methods public and add missing ones#130725
gh-110067: Make max heap methods public and add missing ones#130725encukou merged 27 commits intopython:mainfrom
Conversation
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
There are various things to change. I don't know why we should expose the Python implementation and not the C implementation which is faster.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I was working on the C implementation, my bad! |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I'm converting into a draft until the comments are addressed. In addition, since we are now having code duplication for |
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
I have made the requested changes; please review again We can leave de-duplication for later. |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
Co-authored-by: Petr Viktorin <encukou@gmail.com>
ambv
left a comment
ambv
left a comment
There was a problem hiding this comment.
The issue your PR is solving is called "maxheap version of a heappush", but the PR is missing a C implementation of "heappush_max".
|
I put more suggestions in StanFromIreland#1. |
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
max-heaps: Reword the docs, add more tests
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
One more editing pass, and let's get this into 3.14 beta.
There'll be time until July to adjust the tests/docs/implementation, or revert the feature entirely.
…ythonGH-130725) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
5 participants
Made public, added test (same as normal heap) and added docs.
@rhettinger has not opened the planned PR in ~2 years
📚 Documentation preview 📚: https://cpython-previews--130725.org.readthedocs.build/