X Tutup
Skip to content

gh-130230: Fix crash in pow() with only Decimal third argument#130237

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:decimal-pow-crash
Feb 18, 2025
Merged

gh-130230: Fix crash in pow() with only Decimal third argument#130237
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:decimal-pow-crash

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 17, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label Feb 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 17, 2025
Closed
@skirpichev
Copy link
Member

skirpichev commented Feb 18, 2025

CC @kumaraditya303

@serhiy-storchaka serhiy-storchaka merged commit b93b7e5 into python:main Feb 18, 2025
50 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 18, 2025

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the decimal-pow-crash branch February 18, 2025 07:46
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 18, 2025
@serhiy-storchaka @miss-islington
pythongh-130230: Fix crash in pow() with only Decimal third argument (p…
39e8192 
…ythonGH-130237)

(cherry picked from commit b93b7e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 18, 2025

GH-130246 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 18, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 18, 2025
@serhiy-storchaka
[3.12] pythongh-130230: Fix crash in pow() with only Decimal third ar…
4a29d52 
…gument (pythonGH-130237)

(cherry picked from commit b93b7e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 18, 2025
@serhiy-storchaka
[3.12] pythongh-130230: Add new tests for 3-arg pow() with Decimal (p…
4a8a5c0 
…ythonGH-130237)

(cherry picked from commit b93b7e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 18, 2025

GH-130247 is a backport of this pull request to the 3.12 branch.

@bedevere-bot
Copy link

bedevere-bot commented Feb 18, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit b93b7e5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/2619) and take a look at the build logs.
  4. Check if the failure is related to this commit (b93b7e5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/2619

Failed tests:

  • test__colorize

Failed subtests:

  • test_colorized_detection_checks_for_file - test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_file
  • test_colorized_detection_checks_for_std_streams - test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_std_streams
  • test_colorized_detection_checks_for_environment_variables - test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/B1B1F05B-F9F5-49CF-A120-389D86D49970/data/Containers/Bundle/Application/60E18174-C026-43AB-A88B-EFAD4D4FE247/iOSTestbed.app/python/lib/python3.14/test/test__colorize.py", line 33, in check
    self.assertEqual(_colorize.can_colorize(), expected)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/B1B1F05B-F9F5-49CF-A120-389D86D49970/data/Containers/Bundle/Application/60E18174-C026-43AB-A88B-EFAD4D4FE247/iOSTestbed.app/python/lib/python3.14/test/test__colorize.py", line 101, in test_colorized_detection_checks_for_std_streams
    self.assertEqual(_colorize.can_colorize(), True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/B1B1F05B-F9F5-49CF-A120-389D86D49970/data/Containers/Bundle/Application/60E18174-C026-43AB-A88B-EFAD4D4FE247/iOSTestbed.app/python/lib/python3.14/test/test__colorize.py", line 114, in test_colorized_detection_checks_for_file
    self.assertEqual(_colorize.can_colorize(file=file), True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True

serhiy-storchaka added a commit that referenced this pull request Feb 18, 2025
@serhiy-storchaka
[3.12] gh-130230: Add new tests for 3-arg pow() with Decimal (GH-130237…
4a6415c 
…) (GH-130247)

(cherry picked from commit b93b7e5)
serhiy-storchaka added a commit that referenced this pull request Feb 18, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-130230: Fix crash in pow() with only Decimal third argument (…
5d83b6c 
…GH-130237) (GH-130246)

(cherry picked from commit b93b7e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @skirpichev @bedevere-bot @kumaraditya303
X Tutup