gh-130195: Remove unimplemented option from pygettext#130196
gh-130195: Remove unimplemented option from pygettext#130196gvanrossum merged 7 commits intopython:mainfrom
Conversation
|
Requesting @gvanrossum |
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
gvanrossum
left a comment
There was a problem hiding this comment.
With those two changes I am fine with this (there's a FIXME comment and you never know when someone decides to volunteer to do so :-).
|
@warsaw Are we missing anything here? Maybe we should just remove the -a/--extract-all option? Maybe it's already implemented? What is it even supposed to do? Why is it there? Am I asking too many questions? |
|
Questions are always good ;-) |
|
@gvanrossum To answer your questions:
It's not, it's currently a noop
AFAICT, it was supposed to be the equivalent of the x = 'foo'
y = {'bar': 'baz'}I suggested to deprecate and eventually remove this option because I don't see much use for this option in the context of a gettext extraction tool. You typically only ever want to extract strings which are marked for extraction (e.g. via Yes, we could always implement it, but personally I don't think it'd be that useful so I think removing it makes more sense. |
|
I don’t think we should backport this, we’d be adding a deprecation retroactively. |
|
-a/--extract-all#130195