gh-130179: Fix some references leaks in _pickle#130180
Merged
sobolevn merged 2 commits intopython:mainfrom Feb 16, 2025
Merged
Conversation
Contributor
Author
|
@serhiy-storchaka Please take a look. It seems related to your changes. |
picnixz
approved these changes
Feb 16, 2025
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Indeed, it looks like an oversight.
Member
|
Refs #125752 |
Member
|
(I disabled/enabled the auto-merge because I had a typo in the commit message and it's not possible to edit it after hitting the auto-merge button) |
Member
|
Oh the ARM build is failing with the usual network error. I'll re-disable the auto-merge just in case we need to re-update the PR later. |
|
Thanks @sergey-miryanov for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2025
…_pickle` (pythonGH-130180) (cherry picked from commit e7f00cd) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-130190 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some possible memory leaks in _pickle. This PR fixes it.
Py_CLEAR/Py_VISITcalls forUnpickler.persistent_load_attrandPickler.persistent_id_attr#130179