gh-129843: Fix the wrong argument passed - converting positional argument to named argument#129848
Merged
picnixz merged 4 commits intopython:mainfrom Mar 17, 2025
Merged
gh-129843: Fix the wrong argument passed - converting positional argument to named argument#129848picnixz merged 4 commits intopython:mainfrom
picnixz merged 4 commits intopython:mainfrom
Conversation
argument to named argument
auvipy
reviewed
Feb 13, 2025
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
not sure, if this need an entry to news? it seems to be a kind of bug fix to me, isn't it?
Contributor
Author
|
Yes, It is a bug fix, and i do not think it warrants a news entry. |
Abhisek-Tiwari
added a commit
to Abhisek-Tiwari/cpython
that referenced
this pull request
Mar 14, 2025
picnixz
approved these changes
Mar 14, 2025
Member
It still needs a NEWS IMO because it's still a change that users may be happy to know. Something along the lines "Fix Python implementation of :func:`warnings.warn_explicit`." |
Abhisek-Tiwari
added a commit
to Abhisek-Tiwari/cpython
that referenced
this pull request
Mar 14, 2025
Contributor
Author
|
@picnixz Done |
picnixz
approved these changes
Mar 17, 2025
picnixz
reviewed
Mar 17, 2025
Misc/NEWS.d/next/Library/2025-03-17-15-45-36.gh-issue-129843.NPdpXL.rst
Outdated
Show resolved
Hide resolved
picnixz
added
needs backport to 3.12
|
Thanks @srinivasreddy for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2025
…licit` (pythonGH-129848) The pure Python implementation of `warnings.warn_explicit` constructs a `WarningMessage` with an incorrect source (it incorrectly sets the WarningMessage's line to the given `source`). (cherry picked from commit 80e00ec) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com>
|
GH-131349 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2025
…licit` (pythonGH-129848) The pure Python implementation of `warnings.warn_explicit` constructs a `WarningMessage` with an incorrect source (it incorrectly sets the WarningMessage's line to the given `source`). (cherry picked from commit 80e00ec) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com>
|
GH-131350 is a backport of this pull request to the 3.12 branch. |
picnixz
pushed a commit
that referenced
this pull request
Mar 17, 2025
…plicit` (GH-129848) (#131349) gh-129843: fix pure Python implementation of `warnings.warn_explicit` (GH-129848) The pure Python implementation of `warnings.warn_explicit` constructs a `WarningMessage` with an incorrect source (it incorrectly sets the WarningMessage's line to the given `source`). (cherry picked from commit 80e00ec) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com>
picnixz
pushed a commit
that referenced
this pull request
Mar 17, 2025
…plicit` (GH-129848) (#131350) gh-129843: fix pure Python implementation of `warnings.warn_explicit` (GH-129848) The pure Python implementation of `warnings.warn_explicit` constructs a `WarningMessage` with an incorrect source (it incorrectly sets the WarningMessage's line to the given `source`). (cherry picked from commit 80e00ec) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com>
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…licit` (python#129848) The pure Python implementation of `warnings.warn_explicit` constructs a `WarningMessage` with an incorrect source (it incorrectly sets the WarningMessage's line to the given `source`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.