gh-128657: Run test_hashlib with --parallel-threads#129833
gh-128657: Run test_hashlib with --parallel-threads#129833gpshead merged 3 commits intopython:mainfrom
--parallel-threads#129833Conversation
This catches the race in `py_digest_by_name` that is fixed separately in pythongh-128886.
|
cc @tom-pytel |
|
So the test triggers TSAN but still succeeds. I am guessing the TSAN error output triggers github action to fail? Would it make sense to catpure stderr (in general for tsan tests) so that the tests can fail directly? |
|
The test failed (as expected) before your commit: https://github.com/python/cpython/actions/runs/13209357165/job/36879773663 And now passes (as expected) after your PR was merged (and I merged main back into this PR): https://github.com/python/cpython/actions/runs/13217166856/job/36897772901 |
You are right, command line difference, adding the "-j4" switch makes it fail for me locally as well, without it it succeeds. |
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
thanks for modernizing that test code.
3 participants
This catches the race in
py_digest_by_namethat is fixed separately in gh-128886.