GH-129715: Remove _DYNAMIC_EXIT#129716
Merged
brandtbucher merged 7 commits intopython:mainfrom Feb 7, 2025
Merged
Conversation
brandtbucher
added
performance
brandtbucher
requested review from
Fidget-Spinner and
markshannon
as code owners
Closed
markshannon
approved these changes
Feb 7, 2025
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
I'd like to have stats for the dynamic exit case.
Other than that, looks good.
Fell free to merge once those stats are added.
markshannon
reviewed
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes all of our slowest JIT benchmarks normal again, and 1% faster overall. See the issue for rationale.
_DYNAMIC_EXIT#129715