gh-85795: Fix typing.NamedTuple __classcell__ bug, support overriding __repr__ easily#129344
gh-85795: Fix typing.NamedTuple __classcell__ bug, support overriding __repr__ easily#129344johnslavik wants to merge 8 commits intopython:mainfrom
typing.NamedTuple __classcell__ bug, support overriding __repr__ easily#129344Conversation
__classcell__, support overriding __repr__ easilytyping.NamedTuple __classcell__ bug, support overriding __repr__ easily
96af8ac to
dcdab5f
Compare
|
(Sorry for the force push, but this one was a very tricky and subtle git mistake of mine and I prefer not confusing y'all) |
|
A couple notes on the solution: I added a private parameter I also pop I expect it is not added to typeshed, as it is only intended for internal use. I expect |
|
If you disagree with the addition of |
It would make sense to me to split this PR into two. I'm not necessarily saying I disagree with the |
|
@AlexWaygood Thanks, you're right. I should have split that in the first place. I'll work through all the possible CI problems and then proceed to split it. |
|
Closing this one and opening two new PRs, as concluded in #129344 (comment). |

Closes gh-85795Closes gh-129343I'm open to criticism, especially the documentation part.
I'm elaborating on the solution in further comments.
I'll add the news entry quickly.
📚 Documentation preview 📚: https://cpython-previews--129344.org.readthedocs.build/