gh-128842: collect JIT memory stats via pystats#128941
gh-128842: collect JIT memory stats via pystats#128941brandtbucher merged 4 commits intopython:mainfrom
Conversation
diegorusso
requested review from
brandtbucher and
savannahostrowski
as code owners
|
I deleted the branch by error. It's now restored. |
Collect via pystats the following metrics: * total memory size * code size * trampoline size * data size * padding seze * freed memory size
diegorusso
added
topic-JIT
type-feature
|
This is what the output looks like: https://gist.github.com/diegorusso/51df19523da041035ec819dac18ae958 |
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Thanks for tackling this! The JIT changes look good to me. Really like the histogram, that's super useful information.
@mdboom, looping you in to review the stats changes.
Two very minor requests, if they're easy to do (fine if it's not worth the effort):
- Can capitalize "jit" in the output stats? It looks kind of weird when lowercased like that.
- Can we automatically detect and drop histogram buckets at the low end of the range with 0 values, and start the histogram with the first nonzero value?
I've addressed both points. Also the gist has been updated with the right output. Thanks |
trampoline size is not traced. Signed-off-by: Bojun Ren <bj.ren.coding@outlook.com>
3 participants
Collect via pystats the following metrics:
Also print and histogram of the traces total size.