gh-128016: Improved invalid escape sequence warning message#128020
Merged
vstinner merged 11 commits intopython:mainfrom Jan 15, 2025
Merged
gh-128016: Improved invalid escape sequence warning message#128020vstinner merged 11 commits intopython:mainfrom
vstinner merged 11 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
vstinner
reviewed
Dec 17, 2024
zahlman
reviewed
Dec 18, 2024
zahlman
reviewed
Dec 18, 2024
zahlman
reviewed
Dec 18, 2024
vstinner
reviewed
Dec 18, 2024
Contributor
Author
|
@vstinner How long does it usually take for a PR like this to get merged? |
Member
There is no rule. It depends. |
hugovk
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the warning shown when using an invalid escape sequence by revising it from
SyntaxWarning: invalid escape sequence '\W'to"\W" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\\W"? A raw string is also an option.as proposed in #128016.The purpose is to:
Hello\n World and\or fizz buzz), as suggested by @hugovk.At present, speaking from my own experience, the current message does not communicate very clearly the urgent need to cease using invalid escapes lest you create code that will end up broken and also educate on how to quickly fix the issue.
SyntaxWarningfor invalid escape sequences better reflect their intended deprecation #128016