gh-127734: improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__#127735
Merged
orsenthil merged 1 commit intopython:mainfrom Dec 8, 2024
Merged
gh-127734: improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__#127735orsenthil merged 1 commit intopython:mainfrom
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__#127735orsenthil merged 1 commit intopython:mainfrom
Conversation
orsenthil
added
needs backport to 3.12
|
Thanks @tungol for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @tungol for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 8, 2024
…WithPriorAuth.__init__` (pythonGH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <git@tungol.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 8, 2024
…WithPriorAuth.__init__` (pythonGH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <git@tungol.org>
|
GH-127744 is a backport of this pull request to the 3.13 branch. |
|
GH-127745 is a backport of this pull request to the 3.12 branch. |
orsenthil
pushed a commit
that referenced
this pull request
Dec 8, 2024
…rWithPriorAuth.__init__` (GH-127735) (#127744) gh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (GH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <git@tungol.org>
orsenthil
pushed a commit
that referenced
this pull request
Dec 8, 2024
…rWithPriorAuth.__init__` (GH-127735) (#127745) gh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (GH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <git@tungol.org>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…WithPriorAuth.__init__` (python#127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small MR to improve signature introspection of
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__. The parent class takes no arguments, so the pass-through serves no purpose. Currently, typeshed needs to haveurllib.request.HTTPPasswordMgrWithPriorAuth.__init__on its allowlist for stubtest errors as a result of the poor introspection.urllib.request.HTTPPasswordMgrWithPriorAuth.__init__#127734