X Tutup
Skip to content

gh-127732: Add Windows Server 2025 to platform.py detection#127733

Merged
zooba merged 4 commits intopython:mainfrom
Wulian233:server2025
Dec 9, 2024
Merged

gh-127732: Add Windows Server 2025 to platform.py detection#127733
zooba merged 4 commits intopython:mainfrom
Wulian233:server2025

Conversation

@Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Dec 8, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 8, 2024
Closed
@zooba zooba added OS-windows needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 9, 2024
@zooba zooba merged commit 5eb7fd4 into python:main Dec 9, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 9, 2024

Thanks @Wulian233 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2024
@Wulian233 @miss-islington
pythongh-127732: Add Windows Server 2025 detection to platform module (…
ce1e2b9 
…pythonGH-127733)

(cherry picked from commit 5eb7fd4)

Co-authored-by: Wulian <1055917385@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2024
@Wulian233 @miss-islington
pythongh-127732: Add Windows Server 2025 detection to platform module (…
626a721 
…pythonGH-127733)

(cherry picked from commit 5eb7fd4)

Co-authored-by: Wulian <1055917385@qq.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2024

GH-127762 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 9, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2024

GH-127763 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 9, 2024
zooba pushed a commit that referenced this pull request Dec 9, 2024
@miss-islington @Wulian233
gh-127732: Add Windows Server 2025 detection to platform module (GH-1…
fa93522 
…27733)

(cherry picked from commit 5eb7fd4)

Co-authored-by: Wulian <1055917385@qq.com>
zooba pushed a commit that referenced this pull request Dec 9, 2024
@miss-islington @Wulian233
gh-127732: Add Windows Server 2025 detection to platform module (GH-1…
310efda 
…27733)

(cherry picked from commit 5eb7fd4)

Co-authored-by: Wulian <1055917385@qq.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 9, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.12 has failed when building commit fa93522.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1206/builds/1344) and take a look at the build logs.
  4. Check if the failure is related to this commit (fa93522) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1206/builds/1344

Failed tests:

  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/_test_multiprocessing.py", line 1479, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1075, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_poplib.py", line 235, in run
    asyncore.loop(timeout=0.1, count=1)
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asyncore.py", line 213, in loop
    poll_fun(timeout, map)
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asyncore.py", line 156, in poll
    read(obj)
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asyncore.py", line 93, in read
    obj.handle_error()
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asyncore.py", line 89, in read
    obj.handle_read_event()
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asyncore.py", line 426, in handle_read_event
    self.handle_read()
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_poplib.py", line 203, in handle_read
    asynchat.async_chat.handle_read(self)
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asynchat.py", line 128, in handle_read
    self.handle_error()
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asynchat.py", line 124, in handle_read
    data = self.recv(self.ac_in_buffer_size)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/asyncore.py", line 377, in recv
    data = self.socket.recv(buffer_size)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1232, in recv
    return self.read(buflen)
           ^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.12.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1105, in read
    return self._sslobj.read(len)
           ^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLError: [SYS] unknown error (_ssl.c:2570)
k

@Wulian233 Wulian233 deleted the server2025 branch December 10, 2024 10:14
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@Wulian233 @srinivasreddy
pythongh-127732: Add Windows Server 2025 detection to platform module (…
dd5b3a6 
…pythonGH-127733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@zooba zooba zooba left review comments

@picnixz picnixz picnixz left review comments

Assignees

No one assigned

Labels

OS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Wulian233 @bedevere-bot @hugovk @zooba @picnixz
X Tutup