Revert "gh-126024: fix UBSan failure in unicodeobject.c:find_first_nonascii (GH-127566)"#127695
Closed
colesbury wants to merge 1 commit intopython:mainfrom
Closed
Revert "gh-126024: fix UBSan failure in unicodeobject.c:find_first_nonascii (GH-127566)"#127695colesbury wants to merge 1 commit intopython:mainfrom
unicodeobject.c:find_first_nonascii (GH-127566)"#127695colesbury wants to merge 1 commit intopython:mainfrom
Conversation
…irst_nonascii` (pythonGH-127566)" Some hypothesis tests are failing. This reverts commit 36c6178.
Member
|
Actually, I checked locally and the issue already exists. Can you check the following on a released 3.12 or something like that? So maybe it's not my code that is the issue but something else and the tests were never run for some reason? >>> import binascii
>>> x = b'\n\r\n'
>>> y = binascii.b2a_qp(x, quotetabs=False, istext=True, header=False)
>>> z = binascii.a2b_qp(y, header=False)
>>> x
b'\n\r\n'
>>> z
b'\n\n'This is: https://github.com/python/cpython/actions/runs/12200589926/job/34037087571#step:22:214. |
Contributor
Author
|
Yes, I think you're right. The hypothesis tests run on randomized inputs. I think we need to do a better job of running the tests for longer (on more inputs) when we add new tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some hypothesis tests are failing.
This reverts commit 36c6178.