gh-41872: Parse docstrings with ast instead of string manipulation#127520
Merged
serhiy-storchaka merged 29 commits intopython:mainfrom Jan 8, 2025
Merged
gh-41872: Parse docstrings with ast instead of string manipulation#127520serhiy-storchaka merged 29 commits intopython:mainfrom
serhiy-storchaka merged 29 commits intopython:mainfrom
Conversation
srinivasreddy
changed the title
merwok
reviewed
Dec 2, 2024
…se both single quote doc strings, and double quote doc strings
Co-authored-by: Éric <merwok@netwok.org>
srinivasreddy
force-pushed
the
gh-41872
branch
from
fdbb359 to
abccf04
Compare
srinivasreddy
force-pushed
the
gh-41872
branch
from
1de72bb to
272ca67
Compare
srinivasreddy
changed the title
Contributor
Author
|
I have changed the solution, please let me know your thoughts on it? @merwok |
Member
|
Please avoid force pushes, as indicated in the devguide 🙂 |
merwok
reviewed
Dec 4, 2024
merwok
reviewed
Dec 4, 2024
merwok
changed the title
Co-authored-by: Éric <merwok@netwok.org>
srinivasreddy
commented
Dec 5, 2024
srinivasreddy
commented
Dec 5, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Needs a blurb entry, by the way.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Contributor
Author
|
@serhiy-storchaka Thanks for the suggestions I was in a hurry , left for the day without fixing them . |
merwok
reviewed
Jan 6, 2025
Co-authored-by: Éric <merwok@netwok.org>
Contributor
Author
|
@serhiy-storchaka Thanks for the commit. |
|
Thanks @srinivasreddy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2025
… in pydoc (pythonGH-127520) It now supports docstrings with single quotes, escape sequences, raw string literals, and other Python syntax. (cherry picked from commit 474e419) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Éric <merwok@netwok.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-128620 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2025
… in pydoc (pythonGH-127520) It now supports docstrings with single quotes, escape sequences, raw string literals, and other Python syntax. (cherry picked from commit 474e419) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Éric <merwok@netwok.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-128621 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 8, 2025
…e in pydoc (GH-127520) (GH-128620) It now supports docstrings with single quotes, escape sequences, raw string literals, and other Python syntax. (cherry picked from commit 474e419) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Éric <merwok@netwok.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 8, 2025
…e in pydoc (GH-127520) (GH-128621) It now supports docstrings with single quotes, escape sequences, raw string literals, and other Python syntax. (cherry picked from commit 474e419) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <thatiparthysreenivas@gmail.com> Co-authored-by: Éric <merwok@netwok.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-41872: Instead of manual parsing of docstrings, use ast to parse both single quote docstrings and double quote docstrings