GH-126795: Increase the JIT side-exit threshold from 64 to 4096#127155
Merged
brandtbucher merged 3 commits intopython:mainfrom Dec 4, 2024
Merged
GH-126795: Increase the JIT side-exit threshold from 64 to 4096#127155brandtbucher merged 3 commits intopython:mainfrom
brandtbucher merged 3 commits intopython:mainfrom
Conversation
brandtbucher
added
performance
Member
Author
|
Results across platforms. Very similar to GH-126816, in that it looks like the memory savings are more pronounced on AArch64 macOS and the performance impact is more pronounced on AArch64 Linux.
Another nice win for Arm, @diegorusso. :) |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be covered by the NEWS entry in GH-126816. Looks like a ~0.5% speedup and ~0.5% memory savings, so nothing too dramatic there. Only 1/3 as many traces created though, with no change to the number of uops executed, so the memory and time we're saving does seem like it's completely wasted currently (stats).
I'm running benchmarks across all platforms now.